[PR #193] [MERGED] AuthDB Download Check improvements #200

New issue

Closed

opened 2026-02-28 01:21:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:21:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tuxis-ie/nsedit/pull/193
Author: @margau
Created: 3/1/2020
Status: ✅ Merged
Merged: 11/26/2020
Merged by: @tuxis-ie

Base: master ← Head: master

📝 Commits (2)

6ba23a8 Only run authdb check when user is logged in
82db645 authdb check: Use relative, not absolute path

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 index.php (+7 -1)

📄 Description

Two improvements for the authdb download check:

only check when user is logged in, prevents information leakage (Closes #186 )
Check against testpath, not testurl (relative URL). Prevents Issues introduced from $_SERVER-Variables when nsedit runs behind a reverse proxy

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tuxis-ie/nsedit/pull/193 **Author:** [@margau](https://github.com/margau) **Created:** 3/1/2020 **Status:** ✅ Merged **Merged:** 11/26/2020 **Merged by:** [@tuxis-ie](https://github.com/tuxis-ie) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`6ba23a8`](https://github.com/tuxis-ie/nsedit/commit/6ba23a85b8df2ad23cbb77a35fac911ae128aabe) Only run authdb check when user is logged in - [`82db645`](https://github.com/tuxis-ie/nsedit/commit/82db64595ceaaea94e9e3b3698a0e244a6709c4d) authdb check: Use relative, not absolute path ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `index.php` (+7 -1) </details> ### 📄 Description Two improvements for the authdb download check: - only check when user is logged in, prevents information leakage (Closes #186 ) - Check against testpath, not testurl (relative URL). Prevents Issues introduced from $_SERVER-Variables when nsedit runs behind a reverse proxy --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>