[PR #168] [MERGED] Docker: Move configuration to runtime rather than build time #187

New issue

Closed

opened 2026-02-28 01:21:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:21:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tuxis-ie/nsedit/pull/168
Author: @hreeder
Created: 3/19/2018
Status: ✅ Merged
Merged: 3/28/2018
Merged by: @tuxis-ie

Base: master ← Head: master

📝 Commits (1)

a2d7c21 Move configuration to runtime rather than build time

📊 Changes

2 files changed (+16 additions, -12 deletions)

View changed files

📝 Dockerfile (+3 -12)
➕ docker-entrypoint.sh (+13 -0)

📄 Description

I wanted to deploy this to my docker environment however I don't want our credentials baked in to the image, so I moved the sed lines out from the Dockerfile into an entrypoint script to allow you to set the three configuration variables (IP/Password/Port) at runtime.

I also made it such that the port is optional, and only changes config.inc.php if the environment variable is set.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tuxis-ie/nsedit/pull/168 **Author:** [@hreeder](https://github.com/hreeder) **Created:** 3/19/2018 **Status:** ✅ Merged **Merged:** 3/28/2018 **Merged by:** [@tuxis-ie](https://github.com/tuxis-ie) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`a2d7c21`](https://github.com/tuxis-ie/nsedit/commit/a2d7c216361acdfa742bd067c1fadcfa5564b6f9) Move configuration to runtime rather than build time ### 📊 Changes **2 files changed** (+16 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+3 -12) ➕ `docker-entrypoint.sh` (+13 -0) </details> ### 📄 Description I wanted to deploy this to my docker environment however I don't want our credentials baked in to the image, so I moved the sed lines out from the Dockerfile into an entrypoint script to allow you to set the three configuration variables (IP/Password/Port) at runtime. I also made it such that the port is optional, and only changes `config.inc.php` if the environment variable is set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>