[PR #108] [MERGED] Ability to rotate logs #174

Closed
opened 2026-02-28 01:21:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/tuxis-ie/nsedit/pull/108
Author: @richard-underwood
Created: 8/24/2016
Status: Merged
Merged: 9/13/2016
Merged by: @tuxis-ie

Base: masterHead: issue-107


📝 Commits (10+)

  • d1b8174 Initial implementation of log rotation.
  • 56c1789 Changed "Save logs" to "Download logs" for clarity.
  • f081d96 Allow viewing of past logs.
  • 9d8d909 Remove jtable_respond from the CLI script.
  • ff8df5e Merge remote-tracking branch 'origin/master' into issue-107
  • befb891 Changed Download logs to download the logs currently being shown, not always the current logs - note, doesn't filter first.
  • 2cb95a6 UNRELATED CHANGE - put test around curl_reset to allow testing on PHP 5.4
  • 7c767b7 Merge remote-tracking branch 'origin/master' into issue-107
  • 669c78a Merge remote-tracking branch 'origin/master' into issue-107
  • 8d6e8dd Removed delete button from logs table as the action wasn't implemented and would not be possible on rotated logs.

📊 Changes

5 files changed (+211 additions, -51 deletions)

View changed files

📝 includes/config.inc.php-dist (+5 -0)
📝 includes/misc.inc.php (+52 -0)
📝 index.php (+72 -12)
📝 logs.php (+66 -39)
rotate-logs.php (+16 -0)

📄 Description

This is for #107 - the core work is complete, but it needs testing, particularly with a mix of unusual logging and allow*logs options.

Please don't merge yet, but let me know if you have any comments.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tuxis-ie/nsedit/pull/108 **Author:** [@richard-underwood](https://github.com/richard-underwood) **Created:** 8/24/2016 **Status:** ✅ Merged **Merged:** 9/13/2016 **Merged by:** [@tuxis-ie](https://github.com/tuxis-ie) **Base:** `master` ← **Head:** `issue-107` --- ### 📝 Commits (10+) - [`d1b8174`](https://github.com/tuxis-ie/nsedit/commit/d1b817443c5b34e4b564e31e9dc02e54d8db6188) Initial implementation of log rotation. - [`56c1789`](https://github.com/tuxis-ie/nsedit/commit/56c1789b309d27c850cce25e8ae4ab342e2d26e6) Changed "Save logs" to "Download logs" for clarity. - [`f081d96`](https://github.com/tuxis-ie/nsedit/commit/f081d96b0c52198d78262a9b3096c053e15005cc) Allow viewing of past logs. - [`9d8d909`](https://github.com/tuxis-ie/nsedit/commit/9d8d909c18c486253ddfed8fe29aa3ad0d1a1cae) Remove jtable_respond from the CLI script. - [`ff8df5e`](https://github.com/tuxis-ie/nsedit/commit/ff8df5e5b20e504962f944da16e976f4ab43e0af) Merge remote-tracking branch 'origin/master' into issue-107 - [`befb891`](https://github.com/tuxis-ie/nsedit/commit/befb891174d9a8b6bba400241984499221e487e4) Changed Download logs to download the logs currently being shown, not always the current logs - note, doesn't filter first. - [`2cb95a6`](https://github.com/tuxis-ie/nsedit/commit/2cb95a695932c3c5e34ac1a7e6a3b8a6be80d848) UNRELATED CHANGE - put test around curl_reset to allow testing on PHP 5.4 - [`7c767b7`](https://github.com/tuxis-ie/nsedit/commit/7c767b776959f3fc61c0a273de3193093e029573) Merge remote-tracking branch 'origin/master' into issue-107 - [`669c78a`](https://github.com/tuxis-ie/nsedit/commit/669c78a1dbffed7c06a4a6b489e7edcaf61a9508) Merge remote-tracking branch 'origin/master' into issue-107 - [`8d6e8dd`](https://github.com/tuxis-ie/nsedit/commit/8d6e8ddf55c61ae88c7469a24b67400c6d0e5c5d) Removed delete button from logs table as the action wasn't implemented and would not be possible on rotated logs. ### 📊 Changes **5 files changed** (+211 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `includes/config.inc.php-dist` (+5 -0) 📝 `includes/misc.inc.php` (+52 -0) 📝 `index.php` (+72 -12) 📝 `logs.php` (+66 -39) ➕ `rotate-logs.php` (+16 -0) </details> ### 📄 Description This is for #107 - the core work is complete, but it needs testing, particularly with a mix of unusual logging and allow*logs options. Please don't merge yet, but let me know if you have any comments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 01:21:18 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nsedit#174
No description provided.