[GH-ISSUE #26] Google Themes and https #15

Closed
opened 2026-02-28 01:20:33 +03:00 by kerem · 3 comments
Owner

Originally created by @piwats on GitHub (Feb 18, 2015).
Original GitHub issue: https://github.com/tuxis-ie/nsedit/issues/26

Hello,

I noticed that nsedit is loading some themes from google, which leads to some warnings on my browser when nsedit is accessed via https.

Would it be possible, from the standpoint of security considerations to add those themes directly to nsedit instead loding them from a 3rd-party website?

Originally created by @piwats on GitHub (Feb 18, 2015). Original GitHub issue: https://github.com/tuxis-ie/nsedit/issues/26 Hello, I noticed that nsedit is loading some themes from google, which leads to some warnings on my browser when nsedit is accessed via https. Would it be possible, from the standpoint of security considerations to add those themes directly to nsedit instead loding them from a 3rd-party website?
kerem 2026-02-28 01:20:33 +03:00
  • closed this issue
  • added the
    wontfix
    label
Author
Owner

@tuxis-ie commented on GitHub (Feb 19, 2015):

The calls are done by https://github.com/jquery/jquery-ui, which is automatically included from @jquery's github repo. For some reason they feel it's better to point to http:// instead of // .

This should be pointed to them (I stronly agree with you, BTW)

<!-- gh-comment-id:75016586 --> @tuxis-ie commented on GitHub (Feb 19, 2015): The calls are done by https://github.com/jquery/jquery-ui, which is automatically included from @jquery's github repo. For some reason they feel it's better to point to http:// instead of // . This should be pointed to them (I stronly agree with you, BTW)
Author
Owner

@HLFH commented on GitHub (Jan 27, 2016):

Related to jtable. Fixed. https://github.com/hikalkan/jtable/pull/1888

<!-- gh-comment-id:175890474 --> @HLFH commented on GitHub (Jan 27, 2016): Related to `jtable`. Fixed. https://github.com/hikalkan/jtable/pull/1888
Author
Owner

@tuxis-ie commented on GitHub (Mar 21, 2016):

You can 'fix' this by doing in the root of nsedit checkout:

cd jtable
git pull origin master

This will update you local jtable instance to the lastest version which includes https://github.com/hikalkan/jtable/pull/1888

I'll fix the version that nsedit ships in the submodule way (Just after I found out how to do that ;))

<!-- gh-comment-id:199188104 --> @tuxis-ie commented on GitHub (Mar 21, 2016): You can 'fix' this by doing in the root of nsedit checkout: ``` cd jtable git pull origin master ``` This will update you local jtable instance to the lastest version which includes https://github.com/hikalkan/jtable/pull/1888 I'll fix the version that nsedit ships in the submodule way (Just after I found out how to do that ;))
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nsedit#15
No description provided.