[PR #34] [MERGED] API Protocol and dynamic NS-entry handling #145

New issue

Closed

opened 2026-02-28 01:21:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:21:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tuxis-ie/nsedit/pull/34
Author: @bfbones
Created: 3/2/2015
Status: ✅ Merged
Merged: 10/26/2015
Merged by: @tuxis-ie

Base: master ← Head: master

📝 Commits (2)

0a09deb - added protocol config parameter and handling for it
6d1fe50 changed dynamic NS-entry handling also for import feature

📊 Changes

3 files changed (+36 additions, -54 deletions)

View changed files

📝 includes/config.inc.php-dist (+3 -2)
📝 index.php (+14 -44)
📝 zones.php (+19 -8)

📄 Description

Hello,

as wished my changes for your new revision. I know my implementiation is a little bit dirty, but works fine. It is a little bit tricky to handle the entries of jtables dynamically, so I workarounded it a little bit.
This changes enable the application to handle a unknown amount of NS-entries from config and from template without any problem. Nothing hardcoded (just two NS-entries) any more.
I hope you like it and if you have improvements feel free to mention them.

Thanks

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tuxis-ie/nsedit/pull/34 **Author:** [@bfbones](https://github.com/bfbones) **Created:** 3/2/2015 **Status:** ✅ Merged **Merged:** 10/26/2015 **Merged by:** [@tuxis-ie](https://github.com/tuxis-ie) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`0a09deb`](https://github.com/tuxis-ie/nsedit/commit/0a09deb50a18db98dcec10d4c74bf1e5aa2b1690) - added protocol config parameter and handling for it - [`6d1fe50`](https://github.com/tuxis-ie/nsedit/commit/6d1fe5067146ede5b29a5764b9cb9fcf3d6e98d6) changed dynamic NS-entry handling also for import feature ### 📊 Changes **3 files changed** (+36 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `includes/config.inc.php-dist` (+3 -2) 📝 `index.php` (+14 -44) 📝 `zones.php` (+19 -8) </details> ### 📄 Description Hello, as wished my changes for your new revision. I know my implementiation is a little bit dirty, but works fine. It is a little bit tricky to handle the entries of jtables dynamically, so I workarounded it a little bit. This changes enable the application to handle a unknown amount of NS-entries from config and from template without any problem. Nothing hardcoded (just two NS-entries) any more. I hope you like it and if you have improvements feel free to mention them. Thanks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>