starred/nsedit

Fork 0

mirror of https://github.com/tuxis-ie/nsedit.git synced 2026-04-26 16:15:54 +03:00

[GH-ISSUE #27] Move menu/ appearance #14

New issue

Closed

opened 2026-02-28 01:20:33 +03:00 by kerem · 10 comments

kerem commented

2026-02-28 01:20:33 +03:00

Owner

Originally created by @piwats on GitHub (Feb 19, 2015).
Original GitHub issue: https://github.com/tuxis-ie/nsedit/issues/27

Hello,

I'm using/testing nsedit for a week now and I noticed how strange the menu which consists at this time only of 3 menu entries looks like.

Wouldn't it be nicer if the three menu items could move in a horizontal bar on top of the nsedit view? Also it might be useful if this bar could be fixed during scrolling.

The other thing I noticed about nsedit: DNS entries/records should be printed in a monospace font.
The records are technical, so having a monospace font there would fit it probably better.

Is this possible to change?

Originally created by @piwats on GitHub (Feb 19, 2015). Original GitHub issue: https://github.com/tuxis-ie/nsedit/issues/27 Hello, I'm using/testing nsedit for a week now and I noticed how strange the menu which consists at this time only of 3 menu entries looks like. Wouldn't it be nicer if the three menu items could move in a horizontal bar on top of the nsedit view? Also it might be useful if this bar could be fixed during scrolling. The other thing I noticed about nsedit: DNS entries/records should be printed in a monospace font. The records are technical, so having a monospace font there would fit it probably better. Is this possible to change?

kerem

2026-02-28 01:20:33 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@tuxis-ie commented on GitHub (Feb 24, 2015):

Feel free to write a patch for the menu. The menu is hardly used, so I don't see the use of investing time in it.

As for the fonts, that should be doable to make configurable.

@tuxis-ie commented on GitHub (Feb 24, 2015): Feel free to write a patch for the menu. The menu is hardly used, so I don't see the use of investing time in it. As for the fonts, that should be doable to make configurable.

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@piwats commented on GitHub (Apr 17, 2015):

Here is a quick and dirty patch:

--- base-orig.css       2015-04-17 15:51:08.022126000 +0200
+++ base.css    2015-04-17 15:56:24.412126000 +0200
@@ -11,21 +11,33 @@
 #wrap {
 }
 #menu {
-    width: 10%;
-    float: left;
-    border: 1px solid #DDD;
+    width: 100%;
+    border-bottom: 2px solid #DDD;
     font-family: 'Segoe UI Semilight','Open Sans',Verdana,Arial,Helvetica,sans-serif;
     font-weight: 300;
     font-size: 14px;
     line-height: 1.3;
+    display: inline-block;
+    margin-bottom: 5px;
+}
+
+#menu ul {
+    padding: 0;
+    margin: 0;
+}
+
+#menu ul li {
+    float: right;
+    margin-right: 5px;
 }
+
 #ImportZone {
     height: 0px;
     width: 0px;
 }
 .tables {
     float: right;
-    width: 89%;
+    width: 100%;
     min-width: 500px;
     margin-bottom: 5px;
 }

@piwats commented on GitHub (Apr 17, 2015): Here is a quick and dirty patch: ``` --- base-orig.css 2015-04-17 15:51:08.022126000 +0200 +++ base.css 2015-04-17 15:56:24.412126000 +0200 @@ -11,21 +11,33 @@ #wrap { } #menu { - width: 10%; - float: left; - border: 1px solid #DDD; + width: 100%; + border-bottom: 2px solid #DDD; font-family: 'Segoe UI Semilight','Open Sans',Verdana,Arial,Helvetica,sans-serif; font-weight: 300; font-size: 14px; line-height: 1.3; + display: inline-block; + margin-bottom: 5px; +} + +#menu ul { + padding: 0; + margin: 0; +} + +#menu ul li { + float: right; + margin-right: 5px; } + #ImportZone { height: 0px; width: 0px; } .tables { float: right; - width: 89%; + width: 100%; min-width: 500px; margin-bottom: 5px; } ```

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@tuxis-ie commented on GitHub (Apr 17, 2015):

Welcome to github, where you can create PR's ;) 👍

@tuxis-ie commented on GitHub (Apr 17, 2015): Welcome to github, where you can create PR's ;) :+1:

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@piwats commented on GitHub (Apr 17, 2015):

Sorry for the inconvenience - this will be the next step :)

@piwats commented on GitHub (Apr 17, 2015): Sorry for the inconvenience - this will be the next step :)

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@piwats commented on GitHub (Apr 17, 2015):

That was easier as I expected - see pull request #44 .

@piwats commented on GitHub (Apr 17, 2015): That was easier as I expected - see pull request #44 .

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@tuxis-ie commented on GitHub (Apr 17, 2015):

Yeah, I personally don't like this. But, there nothing a css class and a configoption can't fix. Can you incorporate that in your PR?

@tuxis-ie commented on GitHub (Apr 17, 2015): Yeah, I personally don't like this. But, there nothing a css class and a configoption can't fix. Can you incorporate that in your PR?

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@piwats commented on GitHub (Apr 17, 2015):

What do you mean by a configoption?

something like:

in index.php:

<head>
    <title>NSEdit!</title>
    <link href="jquery-ui/themes/base/jquery.ui.all.css" rel="stylesheet" type="text/css"/>
    <link href="jtable/lib/themes/metro/blue/jtable.min.css" rel="stylesheet" type="text/css"/>
    <link href="css/base.css" rel="stylesheet" type="text/css"/>

 <?php if ($cssadditions === TRUE) { ?>
        <link href="css/additions.css" rel="stylesheet" type="text/css"/>
 <?php } ?>

    <script src="jquery-ui/jquery-1.10.2.js" type="text/javascript"></script>
    <script src="jquery-ui/ui/jquery.ui.core.js" type="text/javascript"></script>
    <script src="jquery-ui/ui/jquery.ui.widget.js" type="text/javascript"></script>
    <script src="jquery-ui/ui/jquery.ui.mouse.js" type="text/javascript"></script>
    <script src="jquery-ui/ui/jquery.ui.draggable.js" type="text/javascript"></script>
    <script src="jquery-ui/ui/jquery.ui.position.js" type="text/javascript"></script>
    <script src="jquery-ui/ui/jquery.ui.button.js" type="text/javascript"></script>
    <script src="jquery-ui/ui/jquery.ui.resizable.js" type="text/javascript"></script>
    <script src="jquery-ui/ui/jquery.ui.dialog.js" type="text/javascript"></script>
    <script src="jtable/lib/jquery.jtable.min.js" type="text/javascript"></script>
    <script src="js/addclear/addclear.js" type="text/javascript"></script>
</head>

together with $cssadditions = TRUE; in config.inc.php and all the css changes in css/additions.css?

@piwats commented on GitHub (Apr 17, 2015): What do you mean by a configoption? something like: in index.php: ``` <head> <title>NSEdit!</title> <link href="jquery-ui/themes/base/jquery.ui.all.css" rel="stylesheet" type="text/css"/> <link href="jtable/lib/themes/metro/blue/jtable.min.css" rel="stylesheet" type="text/css"/> <link href="css/base.css" rel="stylesheet" type="text/css"/> <?php if ($cssadditions === TRUE) { ?> <link href="css/additions.css" rel="stylesheet" type="text/css"/> <?php } ?> <script src="jquery-ui/jquery-1.10.2.js" type="text/javascript"></script> <script src="jquery-ui/ui/jquery.ui.core.js" type="text/javascript"></script> <script src="jquery-ui/ui/jquery.ui.widget.js" type="text/javascript"></script> <script src="jquery-ui/ui/jquery.ui.mouse.js" type="text/javascript"></script> <script src="jquery-ui/ui/jquery.ui.draggable.js" type="text/javascript"></script> <script src="jquery-ui/ui/jquery.ui.position.js" type="text/javascript"></script> <script src="jquery-ui/ui/jquery.ui.button.js" type="text/javascript"></script> <script src="jquery-ui/ui/jquery.ui.resizable.js" type="text/javascript"></script> <script src="jquery-ui/ui/jquery.ui.dialog.js" type="text/javascript"></script> <script src="jtable/lib/jquery.jtable.min.js" type="text/javascript"></script> <script src="js/addclear/addclear.js" type="text/javascript"></script> </head> ``` together with $cssadditions = TRUE; in config.inc.php and all the css changes in css/additions.css?

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@tuxis-ie commented on GitHub (Apr 17, 2015):

Well, I wouldn't call it additions. But I'd say something like "$menutype = 'horizontal|vertical';" And add cssclasses to the appropriate elements.

@tuxis-ie commented on GitHub (Apr 17, 2015): Well, I wouldn't call it additions. But I'd say something like "$menutype = 'horizontal|vertical';" And add cssclasses to the appropriate elements.

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@piwats commented on GitHub (Apr 17, 2015):

Done, see my PR and Pull Req..

@piwats commented on GitHub (Apr 17, 2015): Done, see my PR and Pull Req..

kerem commented

2026-02-28 01:20:34 +03:00

Author

Owner

@tuxis-ie commented on GitHub (Jul 30, 2015):