[PR #122] [CLOSED] feat(lyrics): song info, hide on stop, podcast fix #125

New issue

Closed

opened 2026-02-28 15:42:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 15:42:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/usenocturne/nocturne-ui/pull/122
Author: @angelolz
Created: 10/31/2025
Status: ❌ Closed

Base: main ← Head: feature/lyrics-screen-song-info

📝 Commits (1)

1456094 feat(lyrics): song info, hide on stop, podcast fix

📊 Changes

2 files changed (+29 additions, -7 deletions)

View changed files

📝 src/components/player/NowPlaying.jsx (+24 -7)
📝 src/hooks/useLyrics.js (+5 -0)

📄 Description

This PR includes a couple of changes that includes a new feature and a bug fix:

Song info is added in the lyrics screen. This makes the album art smaller to make sure the info still fits well within the space.
- The title still respects the "Toggle Scrolling Text" option.
When playback has stopped (or current playback has changed to "Not Playing"), the lyrics screen will be hidden.
- When there is no current song playing, the "Show Lyrics" button is disabled and the text is greyed out.
There is currently a bug where if you were to play a podcast episode while the lyric screen is showing, the app will throw an error in console and turn into a black screen. When changing to a podcast episode, the lyrics screen will also be hidden.

Here's a video of the song info in action:
https://github.com/user-attachments/assets/beedb9f5-6b3c-4118-b1d6-a8c4d1d1afcf

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/usenocturne/nocturne-ui/pull/122 **Author:** [@angelolz](https://github.com/angelolz) **Created:** 10/31/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/lyrics-screen-song-info` --- ### 📝 Commits (1) - [`1456094`](https://github.com/usenocturne/nocturne-ui/commit/145609483a23eea43960deca2fac37f82df12df3) feat(lyrics): song info, hide on stop, podcast fix ### 📊 Changes **2 files changed** (+29 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/components/player/NowPlaying.jsx` (+24 -7) 📝 `src/hooks/useLyrics.js` (+5 -0) </details> ### 📄 Description This PR includes a couple of changes that includes a new feature and a bug fix: - Song info is added in the lyrics screen. This makes the album art smaller to make sure the info still fits well within the space. - The title still respects the "Toggle Scrolling Text" option. - When playback has stopped (or current playback has changed to "Not Playing"), the lyrics screen will be hidden. - When there is no current song playing, the "Show Lyrics" button is disabled and the text is greyed out. - There is currently a bug where if you were to play a podcast episode while the lyric screen is showing, the app will throw an error in console and turn into a black screen. When changing to a podcast episode, the lyrics screen will also be hidden. Here's a video of the song info in action: https://github.com/user-attachments/assets/beedb9f5-6b3c-4118-b1d6-a8c4d1d1afcf --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-28 15:42:15 +03:00

closed this issue
added the
pull-request
label

No labels

help wanted

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nocturne-ui#125

No description provided.

Rows
Columns