[PR #87] [MERGED] settings changes, and fix scroll position #117

New issue

Closed

opened 2026-02-28 15:42:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 15:42:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/usenocturne/nocturne-ui/pull/87
Author: @68p
Created: 3/3/2025
Status: ✅ Merged
Merged: 3/3/2025
Merged by: @68p

Base: main ← Head: main

📝 Commits (3)

9fa8bc3 fix(ui): disable horizontal scroll on settings pages
4df2565 fix(navigation): pressing esc in settings goes back 1 page
9b27e0f fix(navigation): reset scroll position when switching tabs

📊 Changes

7 files changed (+39 additions, -1 deletions)

View changed files

📝 src/components/common/navigation/HorizontalScroll.jsx (+4 -0)
📝 src/components/common/navigation/TrackListNavigation.jsx (+4 -0)
📝 src/components/settings/Settings.jsx (+19 -1)
📝 src/hooks/useKeyboardHandlers.js (+5 -0)
📝 src/pages/_app.jsx (+2 -0)
📝 src/pages/index.jsx (+1 -0)
📝 src/styles/globals.css (+4 -0)

📄 Description

fixes:

disabled horizontal scroll on settings pages
esc on settings subpages goes back 1 page, esc on settings main page goes to recent
scroll position resets when switching tabs, previously didn't reset and would put you at same spot in a different tab

issues:

settings submenu has some weird outline thing (see image)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/usenocturne/nocturne-ui/pull/87 **Author:** [@68p](https://github.com/68p) **Created:** 3/3/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@68p](https://github.com/68p) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`9fa8bc3`](https://github.com/usenocturne/nocturne-ui/commit/9fa8bc3dfd169e72e21b6261fa95e1c3f00ec555) fix(ui): disable horizontal scroll on settings pages - [`4df2565`](https://github.com/usenocturne/nocturne-ui/commit/4df25652cfcf791fb7f8576f7c5ff7604f7f4e73) fix(navigation): pressing esc in settings goes back 1 page - [`9b27e0f`](https://github.com/usenocturne/nocturne-ui/commit/9b27e0f40c31000879b99d6b8352b263277539d2) fix(navigation): reset scroll position when switching tabs ### 📊 Changes **7 files changed** (+39 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/components/common/navigation/HorizontalScroll.jsx` (+4 -0) 📝 `src/components/common/navigation/TrackListNavigation.jsx` (+4 -0) 📝 `src/components/settings/Settings.jsx` (+19 -1) 📝 `src/hooks/useKeyboardHandlers.js` (+5 -0) 📝 `src/pages/_app.jsx` (+2 -0) 📝 `src/pages/index.jsx` (+1 -0) 📝 `src/styles/globals.css` (+4 -0) </details> ### 📄 Description fixes: - disabled horizontal scroll on settings pages - esc on settings subpages goes back 1 page, esc on settings main page goes to recent - scroll position resets when switching tabs, previously didn't reset and would put you at same spot in a different tab issues: - settings submenu has some weird outline thing (see image) ![image](https://github.com/user-attachments/assets/52abaa66-7371-47d8-95f6-6800220d293f) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-28 15:42:13 +03:00

closed this issue
added the
pull-request
label

No labels

help wanted

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nocturne-ui#117

No description provided.

Rows
Columns