[PR #83] [MERGED] fixes and features for bluetooth, status bar, etc. #116

New issue

Closed

opened 2026-02-28 15:42:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 15:42:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/usenocturne/nocturne-ui/pull/83
Author: @68p
Created: 2/5/2025
Status: ✅ Merged
Merged: 2/17/2025
Merged by: @brandonsaldan

Base: main ← Head: fixes

📝 Commits (10+)

3600837 fix(auth): fix auto login, stop page refresh
439b127 chore(errors): add e40 for network errors
ae19ef4 fix(network): variety of fixes
c5bbacc chore(icon): fix battery text position
6e0fb48 fix(status bar): status bar works correctly now
c11be6e fix(bluetooth): WIP bluetooth devices menu
f13d0bc feat/fix: restore bt connection to last device
b0c66d2 fix(bluetooth): limit bluetooth requests
ba714df feat: use users timezone to set current time correctly
38ed557 feat: add connect/disconnect device in settings

📊 Changes

8 files changed (+899 additions, -362 deletions)

View changed files

📝 src/components/auth/AuthSelection.jsx (+386 -105)
📝 src/components/bluetooth/BluetoothDevices.jsx (+92 -46)
📝 src/components/common/navigation/Sidebar.jsx (+1 -40)
📝 src/components/common/navigation/StatusBar.jsx (+189 -6)
📝 src/components/icons/BatteryIcon.jsx (+3 -3)
📝 src/components/player/ProgressBar.jsx (+20 -30)
📝 src/constants/errorCodes.js (+1 -0)
📝 src/pages/_app.jsx (+207 -132)

📄 Description

changes:

fix auto login and stop refreshing page once session restored
add e40 for network errors
hide network errors when loading into UI, and return to no network/enable tethering screen if connection lost
status bar appears and disappears according to if device is connected/disconnected, and also shows correct battery percentage
saves previously connected Bluetooth address and reconnects on boot
get timezone from nocturne API and use that to set correct time on status bar
add connect/disconnect/forget functionality to Bluetooth settings menu
start Bluetooth discovery if no address saved and no network
battery icon uses correct font rather than system font

issues:

flashes no network screen on startup (sometimes I think)
network bars still do not work, but those require more nocturned changes
nitpick but battery info starts at 80 then updates to correct value a little later

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/usenocturne/nocturne-ui/pull/83 **Author:** [@68p](https://github.com/68p) **Created:** 2/5/2025 **Status:** ✅ Merged **Merged:** 2/17/2025 **Merged by:** [@brandonsaldan](https://github.com/brandonsaldan) **Base:** `main` ← **Head:** `fixes` --- ### 📝 Commits (10+) - [`3600837`](https://github.com/usenocturne/nocturne-ui/commit/3600837b4850d012100a8faada33f7ac85aac17d) fix(auth): fix auto login, stop page refresh - [`439b127`](https://github.com/usenocturne/nocturne-ui/commit/439b1274fe12dd29a5fa1f836b172dfa7b300ea1) chore(errors): add e40 for network errors - [`ae19ef4`](https://github.com/usenocturne/nocturne-ui/commit/ae19ef4e89e50be047c33b72a91c4cf40fc377a4) fix(network): variety of fixes - [`c5bbacc`](https://github.com/usenocturne/nocturne-ui/commit/c5bbacc0ca0035b64b3384377a6528f2be8e76a0) chore(icon): fix battery text position - [`6e0fb48`](https://github.com/usenocturne/nocturne-ui/commit/6e0fb48d6ea0e716d026d1c3e5da875b5ed7fc1c) fix(status bar): status bar works correctly now - [`c11be6e`](https://github.com/usenocturne/nocturne-ui/commit/c11be6ee7c5a25aea9edd5f494d3061aa328c7ff) fix(bluetooth): WIP bluetooth devices menu - [`f13d0bc`](https://github.com/usenocturne/nocturne-ui/commit/f13d0bc953f682f27ec59b1bc5a2b0cecd6703bb) feat/fix: restore bt connection to last device - [`b0c66d2`](https://github.com/usenocturne/nocturne-ui/commit/b0c66d214a12f1ce2370f1a12c19d02b2a565100) fix(bluetooth): limit bluetooth requests - [`ba714df`](https://github.com/usenocturne/nocturne-ui/commit/ba714dfdae0ca3b5c180b8f2c9995ae9a1822751) feat: use users timezone to set current time correctly - [`38ed557`](https://github.com/usenocturne/nocturne-ui/commit/38ed5574beaf69c23cd8503475f341dcf769075c) feat: add connect/disconnect device in settings ### 📊 Changes **8 files changed** (+899 additions, -362 deletions) <details> <summary>View changed files</summary> 📝 `src/components/auth/AuthSelection.jsx` (+386 -105) 📝 `src/components/bluetooth/BluetoothDevices.jsx` (+92 -46) 📝 `src/components/common/navigation/Sidebar.jsx` (+1 -40) 📝 `src/components/common/navigation/StatusBar.jsx` (+189 -6) 📝 `src/components/icons/BatteryIcon.jsx` (+3 -3) 📝 `src/components/player/ProgressBar.jsx` (+20 -30) 📝 `src/constants/errorCodes.js` (+1 -0) 📝 `src/pages/_app.jsx` (+207 -132) </details> ### 📄 Description changes: - fix auto login and stop refreshing page once session restored - add e40 for network errors - hide network errors when loading into UI, and return to no network/enable tethering screen if connection lost - status bar appears and disappears according to if device is connected/disconnected, and also shows correct battery percentage - saves previously connected Bluetooth address and reconnects on boot - get timezone from nocturne API and use that to set correct time on status bar - add connect/disconnect/forget functionality to Bluetooth settings menu - start Bluetooth discovery if no address saved and no network - battery icon uses correct font rather than system font issues: - flashes no network screen on startup (sometimes I think) - network bars still do not work, but those require more nocturned changes - nitpick but battery info starts at 80 then updates to correct value a little later ![image](https://github.com/user-attachments/assets/56ea7a47-b31a-4104-a456-aac65503f371) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-28 15:42:13 +03:00

closed this issue
added the
pull-request
label

No labels

help wanted

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nocturne-ui#116

No description provided.

Rows
Columns