[PR #78] [CLOSED] fix network check to work correctly #111

New issue

Closed

opened 2026-02-28 15:42:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 15:42:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/usenocturne/nocturne-ui/pull/78
Author: @68p
Created: 1/15/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

3158178 fix(network): variety of fixes for networking
7e1b533 Merge branch 'usenocturne:main' into main

📊 Changes

3 files changed (+220 additions, -142 deletions)

View changed files

📝 src/components/auth/AuthSelection.jsx (+24 -22)
📝 src/lib/networkChecker.js (+8 -20)
📝 src/pages/_app.jsx (+188 -100)

📄 Description

changes:

uses OPTIONS instead of GET request on devices endpoint, fixes network check failing if access token is expired
bluetooth networking works now, instead of it failing the network checks all the time
loads straight into nocturne ui if network check passes and stored credentials are available

issues:

not that I know of

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/usenocturne/nocturne-ui/pull/78 **Author:** [@68p](https://github.com/68p) **Created:** 1/15/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`3158178`](https://github.com/usenocturne/nocturne-ui/commit/31581784388a5465a20b91b2c3ed171e497f0974) fix(network): variety of fixes for networking - [`7e1b533`](https://github.com/usenocturne/nocturne-ui/commit/7e1b53388dd025160e56a11a6c7c9851785e5638) Merge branch 'usenocturne:main' into main ### 📊 Changes **3 files changed** (+220 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `src/components/auth/AuthSelection.jsx` (+24 -22) 📝 `src/lib/networkChecker.js` (+8 -20) 📝 `src/pages/_app.jsx` (+188 -100) </details> ### 📄 Description changes: - uses OPTIONS instead of GET request on devices endpoint, fixes network check failing if access token is expired - bluetooth networking works now, instead of it failing the network checks all the time - loads straight into nocturne ui if network check passes and stored credentials are available issues: - not that I know of --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-28 15:42:12 +03:00

closed this issue
added the
pull-request
label

No labels

help wanted

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nocturne-ui#111

No description provided.

Rows
Columns