[PR #77] [CLOSED] fix network check to work correctly #110

New issue

Closed

opened 2026-02-28 15:42:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 15:42:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/usenocturne/nocturne-ui/pull/77
Author: @68p
Created: 1/13/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (3)

38f2318 fix(network): fix network check to work correctly
fc8c2a7 fix(network): use router instead of reload
62dbb71 partial fix for network check

📊 Changes

3 files changed (+13 additions, -51 deletions)

View changed files

📝 src/components/auth/AuthSelection.jsx (+3 -18)
📝 src/lib/networkChecker.js (+7 -22)
📝 src/pages/_app.jsx (+3 -11)

📄 Description

changes:

uses OPTIONS on /v1 instead of GET on /v1/devices, allows for network check to work when token is expired
remove duplicate network check in authselection.jsx
remove need for access token in network check, caused network check to not work correctly if expired
removed some unused stuff relating to network check

probably could be a lot better, since i've never used js before

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/usenocturne/nocturne-ui/pull/77 **Author:** [@68p](https://github.com/68p) **Created:** 1/13/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`38f2318`](https://github.com/usenocturne/nocturne-ui/commit/38f23189c3a15b37f7b24f9ea9e3433e854fcc1f) fix(network): fix network check to work correctly - [`fc8c2a7`](https://github.com/usenocturne/nocturne-ui/commit/fc8c2a798a8da174961d40ffa93bcca79ddce238) fix(network): use router instead of reload - [`62dbb71`](https://github.com/usenocturne/nocturne-ui/commit/62dbb71b03c8780043bb55fc0248085889f786f6) partial fix for network check ### 📊 Changes **3 files changed** (+13 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `src/components/auth/AuthSelection.jsx` (+3 -18) 📝 `src/lib/networkChecker.js` (+7 -22) 📝 `src/pages/_app.jsx` (+3 -11) </details> ### 📄 Description changes: - uses OPTIONS on /v1 instead of GET on /v1/devices, allows for network check to work when token is expired - remove duplicate network check in authselection.jsx - remove need for access token in network check, caused network check to not work correctly if expired - removed some unused stuff relating to network check probably could be a lot better, since i've never used js before --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-28 15:42:12 +03:00

closed this issue
added the
pull-request
label

No labels

help wanted

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nocturne-ui#110

No description provided.

Rows
Columns