[PR #76] [MERGED] Fix various bugs in Now Playing page #109

Closed
opened 2026-02-28 15:42:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/usenocturne/nocturne-ui/pull/76
Author: @angelolz
Created: 1/10/2025
Status: Merged
Merged: 1/12/2025
Merged by: @brandonsaldan

Base: mainHead: feature/fix-now-playing-bugs


📝 Commits (3)

  • e41aa4e added various changes to now playing ui
  • 6359d5a disable text selection throughout app
  • 5b61d83 slight formatting changes

📊 Changes

2 files changed (+22 additions, -12 deletions)

View changed files

📝 src/pages/now-playing.jsx (+18 -12)
📝 src/styles/globals.css (+4 -0)

📄 Description

  • Clicking on the album art or the "Not Playing" text will bring you to an undefined album. These elements are only interactable when there's current something playing.
  • Prevent items in the actions menu from being clicked on when there's no music playing (Add to Playlist, Enable shuffle/repeat, Show Lyrics)
  • If items in action menu are unavailable, their text will be at 60% opacity.
  • Clicking on unavailable menu items will no longer close the menu. (See screenshot below)
  • Changed the "Already Added" dialog background styling to match the "Switch Device" modal.
    • Added Inter font that's used in the Switch Device modal.
    • Removed the 30% black background opacity and replaced it with #161616 at 100% opacity.
    • Removed the blur (not sure if you want any of these stylings changed, but if not, I can revert back! :))
  • Prevent user text selection throughout the app.
Screenshots

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/usenocturne/nocturne-ui/pull/76 **Author:** [@angelolz](https://github.com/angelolz) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/12/2025 **Merged by:** [@brandonsaldan](https://github.com/brandonsaldan) **Base:** `main` ← **Head:** `feature/fix-now-playing-bugs` --- ### 📝 Commits (3) - [`e41aa4e`](https://github.com/usenocturne/nocturne-ui/commit/e41aa4e916a4a4edac3f6c02e243c3bb0855686a) added various changes to now playing ui - [`6359d5a`](https://github.com/usenocturne/nocturne-ui/commit/6359d5aa3d9742400982cad71b45a9c2617ec909) disable text selection throughout app - [`5b61d83`](https://github.com/usenocturne/nocturne-ui/commit/5b61d83e0d4a43a90fc53ee03c55a69c0a52daaa) slight formatting changes ### 📊 Changes **2 files changed** (+22 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/pages/now-playing.jsx` (+18 -12) 📝 `src/styles/globals.css` (+4 -0) </details> ### 📄 Description - Clicking on the album art or the "Not Playing" text will bring you to an undefined album. These elements are only interactable when there's current something playing. - Prevent items in the actions menu from being clicked on when there's no music playing (Add to Playlist, Enable shuffle/repeat, Show Lyrics) - If items in action menu are unavailable, their text will be at 60% opacity. - Clicking on unavailable menu items will no longer close the menu. _(See screenshot below)_ - Changed the "Already Added" dialog background styling to match the "Switch Device" modal. - Added Inter font that's used in the Switch Device modal. - Removed the 30% black background opacity and replaced it with #161616 at 100% opacity. - Removed the blur (not sure if you want any of these stylings changed, but if not, I can revert back! :)) - Prevent user text selection throughout the app. <details> <summary>Screenshots</summary> ![image](https://github.com/user-attachments/assets/82349e8e-b203-4103-ae59-29573184da77) </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 15:42:12 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nocturne-ui#109
No description provided.