mirror of
https://github.com/d99kris/nmail.git
synced 2026-04-26 09:46:01 +03:00
[GH-ISSUE #78] [Enhancement] Distinct keybindings for reply-to and reply-to-all #68
Labels
No labels
bug
enhancement
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nmail#68
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kabouik on GitHub (May 8, 2021).
Original GitHub issue: https://github.com/d99kris/nmail/issues/78
Originally assigned to: @d99kris on GitHub.
I haven't often needed it, as the default behaviour can easily be turned into a reply-to with
^Kin the CC field, but not everyone knows about this keybinding and many users usually expect to have two different buttons for reply-to and reply-to-all in their GUI client.I also encountered some cases in nmail where the received email was sent in such a way that all co-recipients were not automatically included in CC with the current implementation, and this is where I lacked a forced reply-to-all.
Something like
randRas default would work for instance, but the nmail help bar currently only shows upper case keys.@d99kris commented on GitHub (May 15, 2021):
Support for reply to sender was added in above commit. Default key bindings:
r- reply all (like before)R- reply to sender (new command)For now there will be no UI help bar indication for "reply to sender" (for the reason you mentioned). I have tested a couple of options:
rand upper-caseR⇧R,↑Ror⇫R.But unfortunately neither looks that great in my opinion and for option 2 there's also the issue that not all terminal/fonts can display these characters, so for now I just left that one out. In the future I may need to revisit this and figure out a good indication for shifted (vs. regular) keys.
@Kabouik commented on GitHub (May 17, 2021):
Nice, thanks!
Yes I agree the aesthetics implications of this make a difficult question. I believe discriminating upper case and lower case in
keybindings will be very useful though. It's already hard enough to combine keybindings of a tiling WM + a featureful terminal emulator (like kitty or tilix for instance) + readline keybindings + nmail keybindings. I realized recently how difficult it was to find just one "free" keybinding to replace ^T in nmail because I started using in Kitty for new tabs. Adding Shift in the balance will help, but will require some visual feedback if many keys start using it.
Without seeing it in action, I would say I would probably prefer the more minimal way with just r/R, I'm afraid a symbol for Shift would clutter the view, or cause alignment issues. But maybe other possibilities could be explored, like
'r'reply all/'R'eply', or[r]eply all/[R]eply, or inverted fg/bg for the keybind character. Just listing ideas, I'm not even sure myself yet what I would prefer.@Kabouik commented on GitHub (May 17, 2021):
Also what could help could be a additional function to toggle the help bar on and off. It is already a configuration option, but has to be set in advance. With a toggle key like ? (already in use for the search function, I know, but it's not an usual key for that), users could declutter the view most of the time and show the keybindings just when needed. Using ? for that is classic in many TUIs (where they usually show a full help screen, but just overlaying the help bar would be enough here). One issue is it would not work in the compose view, so that's not a mature idea yet.
@d99kris commented on GitHub (May 18, 2021):
Thanks for the input on lower-case keybindings, I'll keep it in mind and revisit eventually.
With respect to enabling/disabling help bar in run-time, feel free to submit an issue - it should be fairly simple to implement I think. But yeah, the default keybinding may need some consideration.
For some of the commands that today is available in compose and other views, a regular letter is used (with
CTRLmodifier in compose-mode), for exampleV/^Vfor opening external html viewer. So we could consider something similar for toggling helpbar.On 2021-05-17 21:34 Kabouik @.***> wrote: