[GH-ISSUE #65] Avoid crash when terminal is showing too few columns for ncurses UI #58

Closed
opened 2026-03-03 01:19:28 +03:00 by kerem · 3 comments
Owner

Originally created by @Kabouik on GitHub (Jan 13, 2021).
Original GitHub issue: https://github.com/d99kris/nmail/issues/65

Originally assigned to: @d99kris on GitHub.

Obviously nmail cannot be used when the terminal is too narrow, but it would be best to avoid a crash because the width of the terminal can easily change when using a tiling WM and opening an attachment. See here for instance (sorry about the huge blur effect):

https://user-images.githubusercontent.com/7107523/104435695-947a0200-5584-11eb-873b-e2a88aefd0c1.mp4

Other ncurses applications like cmus seem to be more resistant to such situations.

[Edit] I don't mean that as a pressure to push for #42, I think your arguments are perfeclty sound, but this is one of the situations where a pipe function would be useful: for instance to use WM parameters to show the attachment as a floating window instead of a tiling window, and keep the overall layout to just peek temporarily as the attached file.

Originally created by @Kabouik on GitHub (Jan 13, 2021). Original GitHub issue: https://github.com/d99kris/nmail/issues/65 Originally assigned to: @d99kris on GitHub. Obviously nmail cannot be used when the terminal is too narrow, but it would be best to avoid a crash because the width of the terminal can easily change when using a tiling WM and opening an attachment. See here for instance (sorry about the huge blur effect): https://user-images.githubusercontent.com/7107523/104435695-947a0200-5584-11eb-873b-e2a88aefd0c1.mp4 Other ncurses applications like cmus seem to be more resistant to such situations. [Edit] I don't mean that as a pressure to push for #42, I think your arguments are perfeclty sound, but this is one of the situations where a pipe function would be useful: for instance to use WM parameters to show the attachment as a floating window instead of a tiling window, and keep the overall layout to just peek temporarily as the attached file.
kerem closed this issue 2026-03-03 01:19:28 +03:00
Author
Owner

@d99kris commented on GitHub (Jan 14, 2021):

Thanks for reporting! I've implemented a fix which prevents crashes on my Linux and macOS systems, please let me know if you still see this type of crash.

<!-- gh-comment-id:760153174 --> @d99kris commented on GitHub (Jan 14, 2021): Thanks for reporting! I've implemented a fix which prevents crashes on my Linux and macOS systems, please let me know if you still see this type of crash.
Author
Owner

@d99kris commented on GitHub (Jan 14, 2021):

Coming back to #42 I'm still hesitant to add a custom command support, but I'd be open to implementing a "view html" command, which starts a user-specified viewer to display the email. It would match "view html" in compose screen well, so it would be a consistent user interface.

I'll probably add a note in #42 once I've finished the implementation.

<!-- gh-comment-id:760155368 --> @d99kris commented on GitHub (Jan 14, 2021): Coming back to #42 I'm still hesitant to add a custom command support, but I'd be open to implementing a "view html" command, which starts a user-specified viewer to display the email. It would match "view html" in compose screen well, so it would be a consistent user interface. I'll probably add a note in #42 once I've finished the implementation.
Author
Owner

@Kabouik commented on GitHub (Jan 14, 2021):

I confirm you fixed it. That was fast, thanks a lot.

On 2021-01-14 13:02 Kristofer Berggren notifications@github.com wrote:

Thanks for reporting! I've implemented a fix which prevents crashes on
my Linux and macOS systems, please let me know if you still see this
type of crash.


You are receiving this because you authored the thread.
Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.

References

  1. https://github.com/d99kris/nmail/issues/65#issuecomment-760153174

https://github.com/notifications/unsubscribe-auth/ABWHHQ6OGX2RB3NGE3K3LVTSZ3ML5ANCNFSM4WAQ575A

<!-- gh-comment-id:760195269 --> @Kabouik commented on GitHub (Jan 14, 2021): I confirm you fixed it. That was fast, thanks a lot. On 2021-01-14 13:02 Kristofer Berggren <notifications@github.com> wrote: > Thanks for reporting! I've implemented a fix which prevents crashes on > my Linux and macOS systems, please let me know if you still see this > type of crash. > > — > You are receiving this because you authored the thread. > Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe. > > References > > 1. https://github.com/d99kris/nmail/issues/65#issuecomment-760153174 > 2. > https://github.com/notifications/unsubscribe-auth/ABWHHQ6OGX2RB3NGE3K3LVTSZ3ML5ANCNFSM4WAQ575A > >
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nmail#58
No description provided.