mirror of
https://github.com/d99kris/nmail.git
synced 2026-04-26 09:46:01 +03:00
[GH-ISSUE #65] Avoid crash when terminal is showing too few columns for ncurses UI #58
Labels
No labels
bug
enhancement
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nmail#58
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kabouik on GitHub (Jan 13, 2021).
Original GitHub issue: https://github.com/d99kris/nmail/issues/65
Originally assigned to: @d99kris on GitHub.
Obviously nmail cannot be used when the terminal is too narrow, but it would be best to avoid a crash because the width of the terminal can easily change when using a tiling WM and opening an attachment. See here for instance (sorry about the huge blur effect):
https://user-images.githubusercontent.com/7107523/104435695-947a0200-5584-11eb-873b-e2a88aefd0c1.mp4
Other ncurses applications like cmus seem to be more resistant to such situations.
[Edit] I don't mean that as a pressure to push for #42, I think your arguments are perfeclty sound, but this is one of the situations where a pipe function would be useful: for instance to use WM parameters to show the attachment as a floating window instead of a tiling window, and keep the overall layout to just peek temporarily as the attached file.
@d99kris commented on GitHub (Jan 14, 2021):
Thanks for reporting! I've implemented a fix which prevents crashes on my Linux and macOS systems, please let me know if you still see this type of crash.
@d99kris commented on GitHub (Jan 14, 2021):
Coming back to #42 I'm still hesitant to add a custom command support, but I'd be open to implementing a "view html" command, which starts a user-specified viewer to display the email. It would match "view html" in compose screen well, so it would be a consistent user interface.
I'll probably add a note in #42 once I've finished the implementation.
@Kabouik commented on GitHub (Jan 14, 2021):
I confirm you fixed it. That was fast, thanks a lot.
On 2021-01-14 13:02 Kristofer Berggren notifications@github.com wrote: