mirror of
https://github.com/d99kris/nmail.git
synced 2026-04-26 09:46:01 +03:00
[GH-ISSUE #53] [Enhancement] Confirmation prompt on deletion #49
Labels
No labels
bug
enhancement
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nmail#49
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kabouik on GitHub (Sep 14, 2020).
Original GitHub issue: https://github.com/d99kris/nmail/issues/53
Originally assigned to: @d99kris on GitHub.
All sensible actions in nmail require a
y/nconfirmation, except deletion. On the one hand, this is probably best for people who keep their box clean and delete all unnecessary emails, but on the other hand this can be weird that something as irreversible as deletion does not require a confirmation. Other actions have a setting to configure whether or not a confirmation will be necessary, the same would perhaps be useful for deletion too.@d99kris commented on GitHub (Sep 14, 2020):
Hi @Kabouik - thanks for the suggestion. So one of the reasons why this hasn't been added before is that deletion in nmail is implemented as a move to "trash" folder, which generally is a reversible action (navigate to trash folder, then move the email to folder of choice). Anyway, the requested feature is a very simple thing to implement, and I can see that many users will want to confirm such an action, so I'll take a look at adding it in my next round of nmail fixes.
@Kabouik commented on GitHub (Sep 14, 2020):
Right, this totally makes sense with trash actually, I didn't think about it. However, deleted drafts don't go to trash if I am not mistaken, so in that situation an option to add a confirmation step might make sense. It also depends on how many options you want to have at maximum in the configuration file, you may want to avoid unnecessary clutter.
On 2020-09-14 14:14 Kristofer Berggren notifications@github.com wrote:
@Kabouik commented on GitHub (Sep 17, 2020):
My bad, it seems deleted drafts do go into the Trash folder.
On 2020-09-14 14:14 Kristofer Berggren notifications@github.com wrote:
@d99kris commented on GitHub (Oct 11, 2020):
Hi @Kabouik - thanks again for reporting this. I've implemented a confirmation prompt now. It's enabled by default, but can be disabled by setting
delete_without_confirm=1.