[GH-ISSUE #53] [Enhancement] Confirmation prompt on deletion #49

Closed
opened 2026-03-03 01:19:23 +03:00 by kerem · 4 comments
Owner

Originally created by @Kabouik on GitHub (Sep 14, 2020).
Original GitHub issue: https://github.com/d99kris/nmail/issues/53

Originally assigned to: @d99kris on GitHub.

All sensible actions in nmail require a y/n confirmation, except deletion. On the one hand, this is probably best for people who keep their box clean and delete all unnecessary emails, but on the other hand this can be weird that something as irreversible as deletion does not require a confirmation. Other actions have a setting to configure whether or not a confirmation will be necessary, the same would perhaps be useful for deletion too.

Originally created by @Kabouik on GitHub (Sep 14, 2020). Original GitHub issue: https://github.com/d99kris/nmail/issues/53 Originally assigned to: @d99kris on GitHub. All sensible actions in nmail require a `y/n` confirmation, except deletion. On the one hand, this is probably best for people who keep their box clean and delete all unnecessary emails, but on the other hand this can be weird that something as irreversible as deletion does not require a confirmation. Other actions have a setting to configure whether or not a confirmation will be necessary, the same would perhaps be useful for deletion too.
kerem closed this issue 2026-03-03 01:19:23 +03:00
Author
Owner

@d99kris commented on GitHub (Sep 14, 2020):

Hi @Kabouik - thanks for the suggestion. So one of the reasons why this hasn't been added before is that deletion in nmail is implemented as a move to "trash" folder, which generally is a reversible action (navigate to trash folder, then move the email to folder of choice). Anyway, the requested feature is a very simple thing to implement, and I can see that many users will want to confirm such an action, so I'll take a look at adding it in my next round of nmail fixes.

<!-- gh-comment-id:692013244 --> @d99kris commented on GitHub (Sep 14, 2020): Hi @Kabouik - thanks for the suggestion. So one of the reasons why this hasn't been added before is that deletion in nmail is implemented as a move to "trash" folder, which generally is a reversible action (navigate to trash folder, then move the email to folder of choice). Anyway, the requested feature is a very simple thing to implement, and I can see that many users will want to confirm such an action, so I'll take a look at adding it in my next round of nmail fixes.
Author
Owner

@Kabouik commented on GitHub (Sep 14, 2020):

Right, this totally makes sense with trash actually, I didn't think about it. However, deleted drafts don't go to trash if I am not mistaken, so in that situation an option to add a confirmation step might make sense. It also depends on how many options you want to have at maximum in the configuration file, you may want to avoid unnecessary clutter.

On 2020-09-14 14:14 Kristofer Berggren notifications@github.com wrote:

Hi [1]@Kabouik - thanks for the suggestion. So one of the reasons why
this hasn't been added before is that deletion in nmail is implemented
as a move to "trash" folder, which generally is a reversible action
(navigate to trash folder, then move the email to folder of choice).
Anyway, the requested feature is a very simple thing to implement so
I'll take a look at adding it in my next round of nmail fixes.


You are receiving this because you were mentioned.
Reply to this email directly, [2]view it on GitHub, or [3]unsubscribe.

References

  1. https://github.com/Kabouik
  2. https://github.com/d99kris/nmail/issues/53#issuecomment-692013244
  3. https://github.com/notifications/unsubscribe-auth/ABWHHQ6O4QCLO4QXPN47JXTSFYCK3ANCNFSM4RLPS2GQ
<!-- gh-comment-id:692075080 --> @Kabouik commented on GitHub (Sep 14, 2020): Right, this totally makes sense with trash actually, I didn't think about it. However, deleted drafts don't go to trash if I am not mistaken, so in that situation an option to add a confirmation step might make sense. It also depends on how many options you want to have at maximum in the configuration file, you may want to avoid unnecessary clutter. On 2020-09-14 14:14 Kristofer Berggren <notifications@github.com> wrote: > Hi [1]@Kabouik - thanks for the suggestion. So one of the reasons why > this hasn't been added before is that deletion in nmail is implemented > as a move to "trash" folder, which generally is a reversible action > (navigate to trash folder, then move the email to folder of choice). > Anyway, the requested feature is a very simple thing to implement so > I'll take a look at adding it in my next round of nmail fixes. > > — > You are receiving this because you were mentioned. > Reply to this email directly, [2]view it on GitHub, or [3]unsubscribe. > > References > > 1. https://github.com/Kabouik > 2. https://github.com/d99kris/nmail/issues/53#issuecomment-692013244 > 3. https://github.com/notifications/unsubscribe-auth/ABWHHQ6O4QCLO4QXPN47JXTSFYCK3ANCNFSM4RLPS2GQ >
Author
Owner

@Kabouik commented on GitHub (Sep 17, 2020):

My bad, it seems deleted drafts do go into the Trash folder.

On 2020-09-14 14:14 Kristofer Berggren notifications@github.com wrote:

Hi [1]@Kabouik - thanks for the suggestion. So one of the reasons why
this hasn't been added before is that deletion in nmail is implemented
as a move to "trash" folder, which generally is a reversible action
(navigate to trash folder, then move the email to folder of choice).
Anyway, the requested feature is a very simple thing to implement so
I'll take a look at adding it in my next round of nmail fixes.


You are receiving this because you were mentioned.
Reply to this email directly, [2]view it on GitHub, or [3]unsubscribe.

References

  1. https://github.com/Kabouik
  2. https://github.com/d99kris/nmail/issues/53#issuecomment-692013244
  3. https://github.com/notifications/unsubscribe-auth/ABWHHQ6O4QCLO4QXPN47JXTSFYCK3ANCNFSM4RLPS2GQ
<!-- gh-comment-id:694281795 --> @Kabouik commented on GitHub (Sep 17, 2020): My bad, it seems deleted drafts do go into the Trash folder. On 2020-09-14 14:14 Kristofer Berggren <notifications@github.com> wrote: > Hi [1]@Kabouik - thanks for the suggestion. So one of the reasons why > this hasn't been added before is that deletion in nmail is implemented > as a move to "trash" folder, which generally is a reversible action > (navigate to trash folder, then move the email to folder of choice). > Anyway, the requested feature is a very simple thing to implement so > I'll take a look at adding it in my next round of nmail fixes. > > — > You are receiving this because you were mentioned. > Reply to this email directly, [2]view it on GitHub, or [3]unsubscribe. > > References > > 1. https://github.com/Kabouik > 2. https://github.com/d99kris/nmail/issues/53#issuecomment-692013244 > 3. https://github.com/notifications/unsubscribe-auth/ABWHHQ6O4QCLO4QXPN47JXTSFYCK3ANCNFSM4RLPS2GQ >
Author
Owner

@d99kris commented on GitHub (Oct 11, 2020):

Hi @Kabouik - thanks again for reporting this. I've implemented a confirmation prompt now. It's enabled by default, but can be disabled by setting delete_without_confirm=1.

<!-- gh-comment-id:706637679 --> @d99kris commented on GitHub (Oct 11, 2020): Hi @Kabouik - thanks again for reporting this. I've implemented a confirmation prompt now. It's enabled by default, but can be disabled by setting `delete_without_confirm=1`.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nmail#49
No description provided.