[GH-ISSUE #146] Fix compilation warnings on Linux #117

New issue

Closed

opened 2026-03-03 01:19:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:19:56 +03:00

Owner

Originally created by @d99kris on GitHub (Nov 15, 2023).
Original GitHub issue: https://github.com/d99kris/nmail/issues/146

Originally assigned to: @d99kris on GitHub.

Discussed in https://github.com/d99kris/nmail/discussions/144

Latest Linux CI build https://github.com/d99kris/nmail/actions/runs/6516865750/job/17700809994 reports the following compilations warnings:

In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap_types.h:510,
                 from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap.h:44,
                 from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/imapdriver_tools.h:40,
                 from /home/runner/work/nmail/nmail/src/imap.cpp:10:
/home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow]
   83 | void mailstream_cancel(mailstream * s);
      |                                      ^

In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/imapdriver_tools.h:40,
                 from /home/runner/work/nmail/nmail/src/imap.cpp:10:
/home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap.h:160:66: warning: ‘int mailimap_capability(mailimap*, mailimap_capability_data**)’ hides constructor for ‘struct mailimap_capability’ [-Wshadow]
  160 |                         struct mailimap_capability_data ** result);
      |                                                                  ^

In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap_types.h:510,
                 from /home/runner/work/nmail/nmail/src/loghelp.cpp:14:
/home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow]
   83 | void mailstream_cancel(mailstream * s);
      |                                      ^

In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailsmtp_types.h:44,
                 from /home/runner/work/nmail/nmail/src/sasl.cpp:10:
/home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow]
   83 | void mailstream_cancel(mailstream * s);
      |                                      ^

In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailsmtp_types.h:44,
                 from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailsmtp.h:44,
                 from /home/runner/work/nmail/nmail/src/smtp.cpp:19:
/home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow]
   83 | void mailstream_cancel(mailstream * s);
      |                                      ^

In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap_types.h:510,
                 from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap.h:44,
                 from /home/runner/work/nmail/nmail/src/util.cpp:36:
/home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow]
   83 | void mailstream_cancel(mailstream * s);
      |                                      ^

In file included from /home/runner/work/nmail/nmail/src/util.cpp:36:
/home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap.h:160:66: warning: ‘int mailimap_capability(mailimap*, mailimap_capability_data**)’ hides constructor for ‘struct mailimap_capability’ [-Wshadow]
  160 |                         struct mailimap_capability_data ** result);
      |                                                                  ^

While not critical, it would be neat to fix these warnings.

Originally created by @d99kris on GitHub (Nov 15, 2023). Original GitHub issue: https://github.com/d99kris/nmail/issues/146 Originally assigned to: @d99kris on GitHub. ### Discussed in https://github.com/d99kris/nmail/discussions/144 Latest Linux CI build https://github.com/d99kris/nmail/actions/runs/6516865750/job/17700809994 reports the following compilations warnings: ``` In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap_types.h:510, from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap.h:44, from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/imapdriver_tools.h:40, from /home/runner/work/nmail/nmail/src/imap.cpp:10: /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow] 83 | void mailstream_cancel(mailstream * s); | ^ ``` ``` In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/imapdriver_tools.h:40, from /home/runner/work/nmail/nmail/src/imap.cpp:10: /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap.h:160:66: warning: ‘int mailimap_capability(mailimap*, mailimap_capability_data**)’ hides constructor for ‘struct mailimap_capability’ [-Wshadow] 160 | struct mailimap_capability_data ** result); | ^ ``` ``` In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap_types.h:510, from /home/runner/work/nmail/nmail/src/loghelp.cpp:14: /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow] 83 | void mailstream_cancel(mailstream * s); | ^ ``` ``` In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailsmtp_types.h:44, from /home/runner/work/nmail/nmail/src/sasl.cpp:10: /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow] 83 | void mailstream_cancel(mailstream * s); | ^ ``` ``` In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailsmtp_types.h:44, from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailsmtp.h:44, from /home/runner/work/nmail/nmail/src/smtp.cpp:19: /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow] 83 | void mailstream_cancel(mailstream * s); | ^ ``` ``` In file included from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap_types.h:510, from /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap.h:44, from /home/runner/work/nmail/nmail/src/util.cpp:36: /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailstream.h:83:38: warning: ‘void mailstream_cancel(mailstream*)’ hides constructor for ‘struct mailstream_cancel’ [-Wshadow] 83 | void mailstream_cancel(mailstream * s); | ^ ``` ``` In file included from /home/runner/work/nmail/nmail/src/util.cpp:36: /home/runner/work/nmail/nmail/build/ext/libetpan/include/libetpan/mailimap.h:160:66: warning: ‘int mailimap_capability(mailimap*, mailimap_capability_data**)’ hides constructor for ‘struct mailimap_capability’ [-Wshadow] 160 | struct mailimap_capability_data ** result); | ^ ``` While not critical, it would be neat to fix these warnings.