mirror of
https://github.com/ADD-SP/ngx_waf.git
synced 2026-04-26 14:05:52 +03:00
[GH-ISSUE #22] feat: 能否增加一个 Dockerfile ? #149
Labels
No labels
MacOS
Nginx
OpenResty
Tengine
bug
documentation
enhancement
needs-investigation
pull-request
question
stale
stale
stale
timeout
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ngx_waf#149
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xiagw on GitHub (Feb 14, 2021).
Original GitHub issue: https://github.com/ADD-SP/ngx_waf/issues/22
现在用容器的比较多,
可否有一个 官方的Dockerfile
@ADD-SP commented on GitHub (Feb 15, 2021):
在分支
feature-dockerfile上,项目根目录已经增加了Dockerfile,您可以试一下看看行不行。如果没有问题麻烦您关闭这个 issue,如果不行也麻烦提供相关的的信息。@xiagw commented on GitHub (Feb 17, 2021):
提了一个 PR,修改了一下 dockerfile
用docker mult-stage 减小体积,
修改apk 的中国镜像源
整理一下格式
@ADD-SP commented on GitHub (Feb 17, 2021):
我直接搞一个构建好的镜像然后推送到 Docker 仓库上如何?
@xiagw commented on GitHub (Feb 17, 2021):
应该是提供 dockerfile 比较好。
我提交的 PR 里 加参数就用 阿里云中国镜像
docker build -t test/nginx --build-arg=CHANGE_SOURCE=true .
如果直接推送一个 image,不容易被人采用。主要是官方信任问题。
@ADD-SP commented on GitHub (Feb 17, 2021):
这个确实,非官方的 image 我也不敢完全信任。