[PR #102] [CLOSED] Allow libcjson-dev packages to be installed instead of cloning into lib/ #128

New issue

Closed

opened 2026-03-04 12:19:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 12:19:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ADD-SP/ngx_waf/pull/102
Author: @eilandert
Created: 7/26/2022
Status: ❌ Closed

Base: current ← Head: current

📝 Commits (1)

e6152dd Remove hardcoded $ngx_addon_dir/lib/cjson/cJSON.h, it prevents building with installed OS packages (other modules are trying to depend on it). And ngx_waf builds fine without this when libcjson is cloned into the lib/ dir anyway

📊 Changes

1 file changed (+3 additions, -5 deletions)

View changed files

📝 config (+3 -5)

📄 Description

Remove hardcoded $ngx_addon_dir/lib/cjson/cJSON.h, it prevents building with installed OS packages (other modules are trying to depend on it). And ngx_waf builds fine without this when libcjson is cloned into the lib/ dir anyway

Running in production on https://deb.myguard.nl/nginx-modules (where this module is included by the way)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ADD-SP/ngx_waf/pull/102 **Author:** [@eilandert](https://github.com/eilandert) **Created:** 7/26/2022 **Status:** ❌ Closed **Base:** `current` ← **Head:** `current` --- ### 📝 Commits (1) - [`e6152dd`](https://github.com/ADD-SP/ngx_waf/commit/e6152dd377061139184a2ff134069bd475ad8deb) Remove hardcoded $ngx_addon_dir/lib/cjson/cJSON.h, it prevents building with installed OS packages (other modules are trying to depend on it). And ngx_waf builds fine without this when libcjson is cloned into the lib/ dir anyway ### 📊 Changes **1 file changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `config` (+3 -5) </details> ### 📄 Description Remove hardcoded $ngx_addon_dir/lib/cjson/cJSON.h, it prevents building with installed OS packages (other modules are trying to depend on it). And ngx_waf builds fine without this when libcjson is cloned into the lib/ dir anyway Running in production on https://deb.myguard.nl/nginx-modules (where this module is included by the way) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>