[PR #1549] [MERGED] Cloudflare DNS comments #8466

New issue

Closed

opened 2026-03-12 23:57:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-12 23:57:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/0xJacky/nginx-ui/pull/1549
Author: @0xJacky
Created: 2/7/2026
Status: ✅ Merged
Merged: 2/7/2026
Merged by: @0xJacky

Base: dev ← Head: cursor/cloudflare-dns-comments-299c

📝 Commits (3)

ddbd081 feat(dns): add comment support for Cloudflare DNS records
35b3688 fix(dns): decouple comment column visibility and preserve comments in DDNS updates
16dcee1 fix: resolve code duplication and missing comment field in DNS records

📊 Changes

8 files changed (+46 additions, -1 deletions)

View changed files

📝 api/dns/dto.go (+2 -0)
📝 app/src/api/dns.ts (+2 -0)
📝 app/src/views/dns/DNSRecordManager.vue (+8 -1)
📝 app/src/views/dns/components/DNSRecordForm.vue (+8 -0)
📝 app/src/views/dns/components/DNSRecordTable.vue (+13 -0)
📝 internal/dns/ddns.go (+1 -0)
📝 internal/dns/provider.go (+2 -0)
📝 internal/dns/providers/cloudflare/provider.go (+10 -0)

📄 Description

Add support for Cloudflare DNS record comments to allow users to manage descriptive notes for their records.

Cloudflare is one of the DNS providers that supports adding comments to individual DNS records. This PR integrates this feature, allowing users to view, add, and edit comments directly within the application for their Cloudflare-managed domains.

Note

Medium Risk
Touches provider update/create behavior and record payloads; risk is mainly API compatibility and ensuring comments aren’t inadvertently overwritten/cleared for Cloudflare records.

Overview
Adds end-to-end support for DNS record comment when using Cloudflare: the API DTOs, internal dns.Record/RecordInput, and Cloudflare provider now read/write the comment field (including allowing clearing it on update).

Updates the DNS UI to expose the comment only for Cloudflare domains, adding a Comment field in the create/edit drawer and an optional Comment column in the records table, and wiring the value through edit/create payloads.

^{Written by Cursor Bugbot for commit 16dcee1397. This will update automatically on new commits. Configure here.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/0xJacky/nginx-ui/pull/1549 **Author:** [@0xJacky](https://github.com/0xJacky) **Created:** 2/7/2026 **Status:** ✅ Merged **Merged:** 2/7/2026 **Merged by:** [@0xJacky](https://github.com/0xJacky) **Base:** `dev` ← **Head:** `cursor/cloudflare-dns-comments-299c` --- ### 📝 Commits (3) - [`ddbd081`](https://github.com/0xJacky/nginx-ui/commit/ddbd081d80128d4b8af626a275411eab9dfe9baa) feat(dns): add comment support for Cloudflare DNS records - [`35b3688`](https://github.com/0xJacky/nginx-ui/commit/35b36886de0070d5c43d51627043b0ffb3901301) fix(dns): decouple comment column visibility and preserve comments in DDNS updates - [`16dcee1`](https://github.com/0xJacky/nginx-ui/commit/16dcee1397e0fa44df57513932c30cf819446b27) fix: resolve code duplication and missing comment field in DNS records ### 📊 Changes **8 files changed** (+46 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `api/dns/dto.go` (+2 -0) 📝 `app/src/api/dns.ts` (+2 -0) 📝 `app/src/views/dns/DNSRecordManager.vue` (+8 -1) 📝 `app/src/views/dns/components/DNSRecordForm.vue` (+8 -0) 📝 `app/src/views/dns/components/DNSRecordTable.vue` (+13 -0) 📝 `internal/dns/ddns.go` (+1 -0) 📝 `internal/dns/provider.go` (+2 -0) 📝 `internal/dns/providers/cloudflare/provider.go` (+10 -0) </details> ### 📄 Description Add support for Cloudflare DNS record comments to allow users to manage descriptive notes for their records. Cloudflare is one of the DNS providers that supports adding comments to individual DNS records. This PR integrates this feature, allowing users to view, add, and edit comments directly within the application for their Cloudflare-managed domains. --- <a href="https://cursor.com/background-agent?bcId=bc-43c64b0e-b636-4695-8c37-73d1b9c1a7a9"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-43c64b0e-b636-4695-8c37-73d1b9c1a7a9"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>  --- > [!NOTE] > **Medium Risk** > Touches provider update/create behavior and record payloads; risk is mainly API compatibility and ensuring comments aren’t inadvertently overwritten/cleared for Cloudflare records. > > **Overview** > Adds end-to-end support for DNS record `comment` when using Cloudflare: the API DTOs, internal `dns.Record`/`RecordInput`, and Cloudflare provider now read/write the comment field (including allowing clearing it on update). > > Updates the DNS UI to expose the comment only for Cloudflare domains, adding a Comment field in the create/edit drawer and an optional Comment column in the records table, and wiring the value through edit/create payloads. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 16dcee1397e0fa44df57513932c30cf819446b27. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  --- 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.