mirror of
https://github.com/0xJacky/nginx-ui.git
synced 2026-04-25 08:45:58 +03:00
[GH-ISSUE #100] Fresh install with Linux Script does not recognize LE ssl config #5836
Labels
No labels
Q/A
bug
casdoor
dependencies
docker
documentation
duplicate
enhancement
help wanted
invalid
lego
platform:openwrt
platform:windows
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-ui#5836
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cpjet64 on GitHub (Apr 14, 2023).
Original GitHub issue: https://github.com/0xJacky/nginx-ui/issues/100
Describe the bug
I installed nginx-ui to a cloned dedicated reverse proxy VM to test this out.
The VM is already using certbot and certbot-nginx to autorenew ssl certs for all sites.
When I open a site in nginx-ui that already exists with ssl configured through certbot everything looks ok in the advanced view but in the basic view the option Encrypt Website with Lets Encrypt is disabled as shown in the following screen shot
Expected behavior
Certbot preconfiguration enables the button
Info (please complete the following information):
@0xJacky commented on GitHub (Apr 15, 2023):
To be honst, this is not a bug. The switch is used to enable or disable the auto-renew certification function of Nginx UI, and we did not detact the third-party configuration of auto-renew.
However, we may add a new feature that allow users to use the custom command to obtain certifications from other providers like certbot. #16
@cpjet64 commented on GitHub (Apr 15, 2023):
it would be awesome to add a feature that can detect if the ssl certificate lines followed by the # managed by certbot could be detected and toggle on that option. it would be even better if the already made certificates showed up in the cert page.
@0xJacky commented on GitHub (Apr 15, 2023):
You can add the exist cert in cert manager, and then click 'Change certificate' to show the already made cert.
For safaty reason, we will not auto-detect the certificates in the path.
@cpjet64 commented on GitHub (Apr 15, 2023):
So proper usage of the cert portion would be to add the cert manually using the ssl pathing in the conf file and then toggle on the manage button? Would be nice to get some documentation on that portion. thank you!
@0xJacky commented on GitHub (Apr 15, 2023):
No, the original design is not support users to use other auto-cert services. In v1.7.x, the proper usage is toggle the switch on, and then in the pop modal, you will see the nginx-ui obtaining the cert automatically. After obtained the cert, it will be store to the cert manager, and you just need to click the save button in the footer bar, and then the site is encrypted.
@0xJacky commented on GitHub (Apr 15, 2023):
I decided not to implement the automatic detection of "# managed by certbot" for toggling on the switch. The reason is that the switch's value would be stored in the database, and a background scheduled task is responsible for automatically updating the certificates. This task will query the certificates that have enabled auto-renewal. Therefore, adding this feature might lead to errors in the scheduled task.
Instead, I think the better solution is to add a feature that uses custom commands to obtain certificates. Once this feature is developed, you can toggle the switch on and use a custom command to obtain the certificate. Meanwhile, the background scheduled task will also call that command to auto-renew the certificate.
@cpjet64 commented on GitHub (Apr 15, 2023):
^^^^ THIS!!! That sounds perfect!
@leic4u commented on GitHub (Nov 13, 2023):
may I ask that does there is any progress for the feature, which uses custom commands to issuing certificates?