mirror of
https://github.com/0xJacky/nginx-ui.git
synced 2026-04-25 08:45:58 +03:00
[GH-ISSUE #69] No notification of config syntax errors #4472
Labels
No labels
Q/A
bug
casdoor
dependencies
docker
documentation
duplicate
enhancement
help wanted
invalid
lego
platform:openwrt
platform:windows
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-ui#4472
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pksml85 on GitHub (Jan 28, 2023).
Original GitHub issue: https://github.com/0xJacky/nginx-ui/issues/69
First of all, thanks for writing this great software! It will help me manage my servers with ease.
I prefer to edit my site config files using the 'Manage Configs' link (because my configs get messed up by the auto-formatting when using the 'Manage Sites' --> 'Modify' method). Upon saving the file in 'Manage Configs', the changes take effect immediately, which is very nice. But if I forget a trailing semicolon or mess something else up, I am completely unaware of it. Nginx-UI just reports success on the save.
My suggestion would be: upon any config change, run 'nginx -t' to make sure the config is valid. If the config is not valid, don't save the file, but instead make a modal pop up with the error message(s) and give options like "Don't save" or "Save anyway."
Note: When clicking the 'reload nginx' graphic at the top of the UI, the same issue exists. It will report success, even if config errors are detected. Again, a modal would be wonderful indicating the error(s) and have the options "Don't reload" or "Reload anyway."
The problem with both of these features as they are is that a particular site (with syntax errors) may stop functioning and you won't be aware of it. Fixing this would make this software so much more helpful.
Thanks for your consideration!
@0xJacky commented on GitHub (Jan 29, 2023):
Thank you for your appreciation and feedback. This feature will be added in next version.