[PR #267] [MERGED] fix: directive editor background and `Modal` in dark mode #4022

New issue

Closed

opened 2026-02-28 11:58:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 11:58:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/0xJacky/nginx-ui/pull/267
Author: @AnotiaWang
Created: 1/29/2024
Status: ✅ Merged
Merged: 1/29/2024
Merged by: @0xJacky

Base: dev ← Head: fix/frontend-dark-mode

📝 Commits (1)

b9c7d1e fix: directive editor background and Modal in dark mode

📊 Changes

5 files changed (+12 additions, -5 deletions)

View changed files

📝 app/src/language/LINGUAS (+1 -1)
📝 app/src/views/domain/ngx_conf/NgxConfigEditor.vue (+1 -1)
📝 app/src/views/domain/ngx_conf/NgxServer.vue (+1 -1)
📝 app/src/views/domain/ngx_conf/NgxUpstream.vue (+1 -1)
📝 app/src/views/domain/ngx_conf/directive/DirectiveEditorItem.vue (+8 -1)

📄 Description

修复了前端深色模式下的两个问题：

有 3 处 Modal 的导入方式不对，导致在深色模式下 Modal 还是浅色

编辑站点的“指令”部分的注释背景没有适配深色模式

（顺便问一下，Modal 不加背景遮罩是有什么考虑吗？个人感觉层级有点不明显，并且其它一些地方的一些 Modal 又有遮罩

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/0xJacky/nginx-ui/pull/267 **Author:** [@AnotiaWang](https://github.com/AnotiaWang) **Created:** 1/29/2024 **Status:** ✅ Merged **Merged:** 1/29/2024 **Merged by:** [@0xJacky](https://github.com/0xJacky) **Base:** `dev` ← **Head:** `fix/frontend-dark-mode` --- ### 📝 Commits (1) - [`b9c7d1e`](https://github.com/0xJacky/nginx-ui/commit/b9c7d1e7499cc11bb8ef36bfd12a00aa3021121d) fix: directive editor background and `Modal` in dark mode ### 📊 Changes **5 files changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/language/LINGUAS` (+1 -1) 📝 `app/src/views/domain/ngx_conf/NgxConfigEditor.vue` (+1 -1) 📝 `app/src/views/domain/ngx_conf/NgxServer.vue` (+1 -1) 📝 `app/src/views/domain/ngx_conf/NgxUpstream.vue` (+1 -1) 📝 `app/src/views/domain/ngx_conf/directive/DirectiveEditorItem.vue` (+8 -1) </details> ### 📄 Description 修复了前端深色模式下的两个问题： 1. 有 3 处 `Modal` 的导入方式不对，导致在深色模式下 Modal 还是浅色 <img width="533" alt="截屏2024-01-29 11 46 06" src="https://github.com/0xJacky/nginx-ui/assets/62269186/d3bbe3e0-63b7-4840-9cfc-66c327774429"> 2. 编辑站点的“指令”部分的注释背景没有适配深色模式 <img width="1262" alt="image" src="https://github.com/0xJacky/nginx-ui/assets/62269186/a656ae24-5fbc-46a6-9d1e-80fe7d740391"> （顺便问一下，Modal 不加背景遮罩是有什么考虑吗？个人感觉层级有点不明显，并且其它一些地方的一些 Modal 又有遮罩 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>