[PR #1546] [MERGED] Propfind method logging #1334

New issue

Closed

opened 2026-02-26 12:11:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:11:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/0xJacky/nginx-ui/pull/1546
Author: @0xJacky
Created: 2/6/2026
Status: ✅ Merged
Merged: 2/7/2026
Merged by: @0xJacky

Base: dev ← Head: cursor/propfind-method-logging-33b5

📝 Commits (1)

36ef128 fix: add WebDAV methods (PROPFIND, PROPPATCH, MKCOL, etc.) to ValidHTTPMethods

📊 Changes

3 files changed (+45 additions, -1 deletions)

View changed files

📝 internal/nginx_log/indexer/parallel_indexer_optimized.go (+4 -0)
📝 internal/nginx_log/parser/parser_test.go (+31 -0)
📝 internal/nginx_log/parser/types.go (+10 -1)

📄 Description

Add WebDAV HTTP methods to the Nginx log parser and indexer to correctly process WebDAV requests.

Previously, WebDAV methods like PROPFIND were not recognized by the log parser, leading to these requests being dropped or having an empty method field in structured logs. This PR updates the ValidHTTPMethods map and the indexer's validation logic to include common WebDAV methods and adds corresponding test cases.

Note

Low Risk
Small, additive change to method allowlists plus tests; risk is limited to slightly broader acceptance of log entries during parsing/indexing.

Overview
Extends HTTP method handling to recognize common WebDAV verbs (e.g., PROPFIND, MKCOL, LOCK, COPY, MOVE, UNLOCK) so these requests populate method during parsing and pass index-time validation.

Adds parser test coverage for WebDAV request lines to ensure these methods are extracted correctly (including expected status/bytes fields).

^{Written by Cursor Bugbot for commit 36ef12843e. This will update automatically on new commits. Configure here.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/0xJacky/nginx-ui/pull/1546 **Author:** [@0xJacky](https://github.com/0xJacky) **Created:** 2/6/2026 **Status:** ✅ Merged **Merged:** 2/7/2026 **Merged by:** [@0xJacky](https://github.com/0xJacky) **Base:** `dev` ← **Head:** `cursor/propfind-method-logging-33b5` --- ### 📝 Commits (1) - [`36ef128`](https://github.com/0xJacky/nginx-ui/commit/36ef12843e2ea2863cfea87a29b0c2a8f3f10e05) fix: add WebDAV methods (PROPFIND, PROPPATCH, MKCOL, etc.) to ValidHTTPMethods ### 📊 Changes **3 files changed** (+45 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/nginx_log/indexer/parallel_indexer_optimized.go` (+4 -0) 📝 `internal/nginx_log/parser/parser_test.go` (+31 -0) 📝 `internal/nginx_log/parser/types.go` (+10 -1) </details> ### 📄 Description Add WebDAV HTTP methods to the Nginx log parser and indexer to correctly process WebDAV requests. Previously, WebDAV methods like `PROPFIND` were not recognized by the log parser, leading to these requests being dropped or having an empty method field in structured logs. This PR updates the `ValidHTTPMethods` map and the indexer's validation logic to include common WebDAV methods and adds corresponding test cases. --- <a href="https://cursor.com/background-agent?bcId=bc-16073230-57fe-4ed8-8b83-9cd7f2100808"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-16073230-57fe-4ed8-8b83-9cd7f2100808"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>  --- > [!NOTE] > **Low Risk** > Small, additive change to method allowlists plus tests; risk is limited to slightly broader acceptance of log entries during parsing/indexing. > > **Overview** > Extends HTTP method handling to recognize common WebDAV verbs (e.g., `PROPFIND`, `MKCOL`, `LOCK`, `COPY`, `MOVE`, `UNLOCK`) so these requests populate `method` during parsing and pass index-time validation. > > Adds parser test coverage for WebDAV request lines to ensure these methods are extracted correctly (including expected status/bytes fields). > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 36ef12843e2ea2863cfea87a29b0c2a8f3f10e05. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  --- 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.