starred/nginx-proxy-manager-NginxProxyManager

Fork 0

mirror of https://github.com/NginxProxyManager/nginx-proxy-manager.git synced 2026-04-26 01:45:54 +03:00

[GH-ISSUE #554] Letsencrpyt with DNS challenge #467

New issue

Closed

opened 2026-02-26 06:32:57 +03:00 by kerem · 7 comments

kerem commented

2026-02-26 06:32:57 +03:00

Owner

Originally created by @jiatao99 on GitHub (Aug 12, 2020).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/554

I managed to make the WebGui works with letsencrypt with dns challenge. However, I found a bug in your backend/internal/certificate.js line 735:

			'--preferred-challenges "dns,http" ' +
			'--webroot ' +

Those two line is unnecessary and should be removed because those two value can be specified in line 731: '--config "' + le_config + '" ' +

By just install the certbot-dns-cloudflare in the docker build and modify the ini file with the above changes, I make the dns challenge works with existing GUI.

I you want, I can create a branch and pull request for my changes.

Thanks for your great project.

Originally created by @jiatao99 on GitHub (Aug 12, 2020). Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/554 I managed to make the WebGui works with letsencrypt with dns challenge. However, I found a bug in your ```backend/internal/certificate.js``` line 735: ``` '--preferred-challenges "dns,http" ' + '--webroot ' + ``` Those two line is unnecessary and should be removed because those two value can be specified in line 731: `'--config "' + le_config + '" ' +` By just install the `certbot-dns-cloudflare` in the docker build and modify the ini file with the above changes, I make the dns challenge works with existing GUI. I you want, I can create a branch and pull request for my changes. Thanks for your great project.

kerem

2026-02-26 06:32:57 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-26 06:32:58 +03:00

Author

Owner

@jiatao99 commented on GitHub (Aug 12, 2020):

Also is it possible to allow user to set renew interval (from configure)? It is now hard coded here

	interval_timeout:    1000 * 60 * 60, // 1 hour

Since the cert expires every 90 days. Set it to 1 hour is way too much.

@jiatao99 commented on GitHub (Aug 12, 2020): Also is it possible to allow user to set renew interval (from configure)? It is now hard coded here ``` interval_timeout: 1000 * 60 * 60, // 1 hour ``` Since the cert expires every 90 days. Set it to 1 hour is way too much.

kerem commented

2026-02-26 06:32:58 +03:00

Author

Owner

@cristiangauma commented on GitHub (Aug 20, 2020):

I would be really interested in this feature. Would the DNS challenge work for wildcard domains? (*.foo.bar)

@cristiangauma commented on GitHub (Aug 20, 2020): I would be really interested in this feature. Would the DNS challenge work for wildcard domains? (*.foo.bar)

kerem commented

2026-02-26 06:32:58 +03:00

Author

Owner

@jiatao99 commented on GitHub (Aug 21, 2020):

yes. wild card letsencrypt work on my docker. But I must change their source code. It seems like the owner of this repo does not care about this feature.

@jiatao99 commented on GitHub (Aug 21, 2020): yes. wild card letsencrypt work on my docker. But I must change their source code. It seems like the owner of this repo does not care about this feature.

kerem commented

2026-02-26 06:32:58 +03:00

Author

Owner

@gregfr commented on GitHub (Aug 24, 2020):

I would love to be able to use wildcard certs automatically, because I use NPM for several servers reachable with the same name.

@gregfr commented on GitHub (Aug 24, 2020): I would love to be able to use wildcard certs automatically, because I use NPM for several servers reachable with the same name.

kerem commented

2026-02-26 06:32:58 +03:00

Author

Owner

@micha1983 commented on GitHub (Aug 25, 2020):

would be cool if you share it. i'm also very interested in this feature. i also use cloudflare for DNS.

@micha1983 commented on GitHub (Aug 25, 2020): would be cool if you share it. i'm also very interested in this feature. i also use cloudflare for DNS.

kerem commented

2026-02-26 06:32:58 +03:00

Author

Owner

@jiatao99 commented on GitHub (Aug 25, 2020):

I am using a 3rd party docker image (from jlessage) which allows me to reference the cloudflare secret outside the docker. I shared the process here: https://github.com/jlesage/docker-nginx-proxy-manager/issues/101. Hopefully the owner of that project will provide a docker image which allows cloudflare or other dns plugins

@jiatao99 commented on GitHub (Aug 25, 2020): I am using a 3rd party docker image (from jlessage) which allows me to reference the cloudflare secret outside the docker. I shared the process here: https://github.com/jlesage/docker-nginx-proxy-manager/issues/101. Hopefully the owner of that project will provide a docker image which allows cloudflare or other dns plugins

kerem commented

2026-02-26 06:32:58 +03:00

Author

Owner

@chaptergy commented on GitHub (May 9, 2021):

DNS challenges for many providers are available since mid to end of 2020, which should have also fixed this issue.

@chaptergy commented on GitHub (May 9, 2021): DNS challenges for many providers are available since mid to end of 2020, which should have also fixed this issue.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#467

No description provided.

Rows
Columns