[PR #5117] Simplify SSL redirection logic in Nginx config #4063

Open
opened 2026-02-26 08:33:00 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/5117
Author: @InvisibleDuck
Created: 1/2/2026
Status: 🔄 Open

Base: developHead: patch-1


📝 Commits (1)

  • 37021de Simplify SSL redirection logic in Nginx config

📊 Changes

1 file changed (+5 additions, -8 deletions)

View changed files

📝 docker/rootfs/etc/nginx/conf.d/include/force-ssl.conf (+5 -8)

📄 Description

Force SSL logic to determine acme challenges is wrong which makes all http requests (including acme challenges) redirect to https counterpart. A simplification to this include file fixes this.

I have tested with overwriting the file by adding this line to docker-compose.yml:

volumes:
  - ./force-ssl.conf:/etc/nginx/conf.d/include/force-ssl.conf

Fixes #3979


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/5117 **Author:** [@InvisibleDuck](https://github.com/InvisibleDuck) **Created:** 1/2/2026 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`37021de`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/37021debc291b9ae34994f4f49599d55d5c0c54b) Simplify SSL redirection logic in Nginx config ### 📊 Changes **1 file changed** (+5 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `docker/rootfs/etc/nginx/conf.d/include/force-ssl.conf` (+5 -8) </details> ### 📄 Description Force SSL logic to determine acme challenges is wrong which makes all http requests (including acme challenges) redirect to https counterpart. A simplification to this include file fixes this. I have tested with overwriting the file by adding this line to docker-compose.yml: ``` volumes: - ./force-ssl.conf:/etc/nginx/conf.d/include/force-ssl.conf ``` Fixes #3979 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#4063
No description provided.