[PR #4651] [MERGED] v2.12.5 #3926

Closed
opened 2026-02-26 08:32:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4651
Author: @jc21
Created: 7/9/2025
Status: Merged
Merged: 7/9/2025
Merged by: @jc21

Base: masterHead: develop


📝 Commits (10+)

  • 3735f3c Formating for ownership script
  • aade8b4 Revert "Update 'global/certbot-dns-plugins.json' to apply SSL certs for CloudFlare."
  • ddd3355 Merge pull request #4645 from NginxProxyManager/revert-4574-develop
  • db9f256 Update PR comments to highlight verification requirements
  • 36e3449 Update cloudflare dependency
  • 817021a Update s6 overlay
  • 70894e5 Remove cloudflare dep for certbot plugin, tested
  • ed1d90e Fix powerdns dns plugin install, deps are outrageously old ;(
  • c97b8a3 Some auto formatting changes suggested by ide
  • 5f54490 Set SETUPTOOLS_USE_DISTUTILS for all plugin installs, seems like they all need it.

📊 Changes

18 files changed (+90 additions, -75 deletions)

View changed files

📝 .version (+1 -1)
📝 Jenkinsfile (+10 -5)
📝 README.md (+1 -1)
📝 backend/lib/certbot.js (+12 -5)
📝 backend/lib/utils.js (+9 -9)
📝 docker/rootfs/etc/s6-overlay/s6-rc.d/prepare/30-ownership.sh (+15 -12)
📝 docker/scripts/install-s6 (+1 -1)
📝 global/certbot-dns-plugins.json (+9 -9)
📝 test/cypress/e2e/api/Certificates.cy.js (+3 -3)
📝 test/cypress/e2e/api/Dashboard.cy.js (+1 -1)
📝 test/cypress/e2e/api/FullCertProvision.cy.js (+2 -2)
📝 test/cypress/e2e/api/Health.cy.js (+3 -3)
📝 test/cypress/e2e/api/Ldap.cy.js (+3 -3)
📝 test/cypress/e2e/api/OAuth.cy.js (+3 -3)
📝 test/cypress/e2e/api/ProxyHosts.cy.js (+1 -1)
📝 test/cypress/e2e/api/Settings.cy.js (+7 -7)
📝 test/cypress/e2e/api/Streams.cy.js (+6 -6)
📝 test/cypress/e2e/api/Users.cy.js (+3 -3)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4651 **Author:** [@jc21](https://github.com/jc21) **Created:** 7/9/2025 **Status:** ✅ Merged **Merged:** 7/9/2025 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `master` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`3735f3c`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/3735f3c11d0dc3d2447250829c20f3d09093c006) Formating for ownership script - [`aade8b4`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/aade8b42fcde02423561c4114efd073f6c74b7ed) Revert "Update 'global/certbot-dns-plugins.json' to apply SSL certs for CloudFlare." - [`ddd3355`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/ddd3355d95ed8aa1ab64bc8414472e4371d63def) Merge pull request #4645 from NginxProxyManager/revert-4574-develop - [`db9f256`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/db9f25638f25386a821665116ce25e11c6350a99) Update PR comments to highlight verification requirements - [`36e3449`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/36e3449a56456f50b0b30ffadc4dfc604994bfe7) Update cloudflare dependency - [`817021a`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/817021a43df959d7285354a388fb1c24da0bc243) Update s6 overlay - [`70894e5`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/70894e55b8f84a3728bf785d4a7460b0d99923a5) Remove cloudflare dep for certbot plugin, tested - [`ed1d90e`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/ed1d90ee7ff521dee0088e952ce37b3c394be329) Fix powerdns dns plugin install, deps are outrageously old ;( - [`c97b8a3`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c97b8a339d7610677de7e7dda4a9b692d376d13b) Some auto formatting changes suggested by ide - [`5f54490`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/5f54490d86fa79f2abccbdbcee3e01f656525959) Set SETUPTOOLS_USE_DISTUTILS for all plugin installs, seems like they all need it. ### 📊 Changes **18 files changed** (+90 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `.version` (+1 -1) 📝 `Jenkinsfile` (+10 -5) 📝 `README.md` (+1 -1) 📝 `backend/lib/certbot.js` (+12 -5) 📝 `backend/lib/utils.js` (+9 -9) 📝 `docker/rootfs/etc/s6-overlay/s6-rc.d/prepare/30-ownership.sh` (+15 -12) 📝 `docker/scripts/install-s6` (+1 -1) 📝 `global/certbot-dns-plugins.json` (+9 -9) 📝 `test/cypress/e2e/api/Certificates.cy.js` (+3 -3) 📝 `test/cypress/e2e/api/Dashboard.cy.js` (+1 -1) 📝 `test/cypress/e2e/api/FullCertProvision.cy.js` (+2 -2) 📝 `test/cypress/e2e/api/Health.cy.js` (+3 -3) 📝 `test/cypress/e2e/api/Ldap.cy.js` (+3 -3) 📝 `test/cypress/e2e/api/OAuth.cy.js` (+3 -3) 📝 `test/cypress/e2e/api/ProxyHosts.cy.js` (+1 -1) 📝 `test/cypress/e2e/api/Settings.cy.js` (+7 -7) 📝 `test/cypress/e2e/api/Streams.cy.js` (+6 -6) 📝 `test/cypress/e2e/api/Users.cy.js` (+3 -3) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 08:32:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3926
No description provided.