[PR #4615] [CLOSED] Revert certbot-dns-plugins.json changes to credentials placeholder #3917

New issue

Closed

opened 2026-02-26 08:32:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:32:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4615
Author: @picnicbob
Created: 7/1/2025
Status: ❌ Closed

Base: develop ← Head: Revert-4574

📝 Commits (1)

2fb3b19 Revert "Merge pull request #4574 from tom-kst/develop"

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 global/certbot-dns-plugins.json (+1 -1)

📄 Description

Storing user/global API key instead of an API token is not a good idea and specifically not recommended by certbot-dns-cloudflare documentation.
Spaces were intentionally removed in the past by #3781.
dns_cloudflare_api_token=abc123 was/is working fine for me.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4615 **Author:** [@picnicbob](https://github.com/picnicbob) **Created:** 7/1/2025 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `Revert-4574` --- ### 📝 Commits (1) - [`2fb3b19`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/2fb3b1989122de045de426a1a2ea2bfad6323cfb) Revert "Merge pull request #4574 from tom-kst/develop" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `global/certbot-dns-plugins.json` (+1 -1) </details> ### 📄 Description Storing user/global API key instead of an API token is not a good idea and specifically not recommended by [certbot-dns-cloudflare documentation](https://certbot-dns-cloudflare.readthedocs.io/en/stable/index.html#certbot-cloudflare-token-ini). Spaces were intentionally removed in the past by #3781. `dns_cloudflare_api_token=abc123` was/is working fine for me. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:32:26 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3917

No description provided.

Rows
Columns