[PR #4425] Adds feature to Edit Custom certificates. #3880

New issue

Open

opened 2026-02-26 08:32:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:32:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4425
Author: @rumansaleem
Created: 3/8/2025
Status: 🔄 Open

Base: develop ← Head: feature/edit-custom-certificates

📝 Commits (2)

fe3c922 Adds feature to Edit Custom certificates.
b9bf340 fix infinite recursion.

📊 Changes

10 files changed (+158 additions, -17 deletions)

View changed files

📝 backend/internal/certificate.js (+3 -1)
📝 backend/routes/nginx/certificates.js (+18 -0)
➕ backend/schema/paths/nginx/certificates/certID/put.json (+77 -0)
📝 backend/schema/swagger.json (+3 -0)
📝 frontend/js/app/nginx/certificates/form.ejs (+13 -5)
📝 frontend/js/app/nginx/certificates/form.js (+25 -10)
📝 frontend/js/app/nginx/certificates/list/item.ejs (+4 -0)
📝 frontend/js/app/nginx/certificates/list/item.js (+6 -0)
📝 frontend/js/i18n/messages.json (+2 -1)
📝 frontend/js/models/certificate.js (+7 -0)

📄 Description

Closes #1618 & #1911

Adds a PUT API to update certificate data (using only nice_name for now). The method to call this API already existed in client-side.
Updates the existing Form UI & Logic:
- Conditionally calls updating or creating a certificate.
- Makes certificates non-required in case of editing
- Existing API call to upload files to existing certificate, replaces the existing files, in case files already exists.

Screenshots

Edit Menu (only for custom certificates)

Edit Form (re-uses existing form)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4425 **Author:** [@rumansaleem](https://github.com/rumansaleem) **Created:** 3/8/2025 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `feature/edit-custom-certificates` --- ### 📝 Commits (2) - [`fe3c922`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/fe3c92247f376eb2810ab6044719572b578b6ba1) Adds feature to Edit Custom certificates. - [`b9bf340`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/b9bf340fcfebf3892b56e22fcc667725c645ac67) fix infinite recursion. ### 📊 Changes **10 files changed** (+158 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/certificate.js` (+3 -1) 📝 `backend/routes/nginx/certificates.js` (+18 -0) ➕ `backend/schema/paths/nginx/certificates/certID/put.json` (+77 -0) 📝 `backend/schema/swagger.json` (+3 -0) 📝 `frontend/js/app/nginx/certificates/form.ejs` (+13 -5) 📝 `frontend/js/app/nginx/certificates/form.js` (+25 -10) 📝 `frontend/js/app/nginx/certificates/list/item.ejs` (+4 -0) 📝 `frontend/js/app/nginx/certificates/list/item.js` (+6 -0) 📝 `frontend/js/i18n/messages.json` (+2 -1) 📝 `frontend/js/models/certificate.js` (+7 -0) </details> ### 📄 Description Closes #1618 & #1911 - Adds a PUT API to update certificate data (using only nice_name for now). The method to call this API already existed in client-side. - Updates the existing Form UI & Logic: - Conditionally calls updating or creating a certificate. - Makes certificates non-required in case of editing - Existing API call to upload files to existing certificate, replaces the existing files, in case files already exists. ### Screenshots ![image](https://github.com/user-attachments/assets/6976fb8e-f691-41b4-9bde-db2a0291eb32) Edit Menu (only for custom certificates) ![image](https://github.com/user-attachments/assets/1fd0a22e-4980-4e46-a242-4a496ee7a735) Edit Form (re-uses existing form) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-26 08:32:18 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3880

No description provided.

Rows
Columns