[PR #4338] [MERGED] Fix type for token.expires #3863

New issue

Closed

opened 2026-02-26 08:32:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:32:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4338
Author: @Sander0542
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/5/2025
Merged by: @jc21

Base: develop ← Head: fix/token-expires-type

📝 Commits (1)

57cd2a1 Fix type for token.expires

📊 Changes

3 files changed (+5 additions, -6 deletions)

View changed files

📝 backend/schema/components/token-object.json (+3 -4)
📝 backend/schema/paths/tokens/get.json (+1 -1)
📝 backend/schema/paths/tokens/post.json (+1 -1)

📄 Description

Currently, the token.expires property is advertised as an interger in the api schema, but the API returns a ISO string. I updated the schema to match the actual API.

github.com/NginxProxyManager/nginx-proxy-manager@b4f49969d6/backend/internal/token.js (L70)

github.com/NginxProxyManager/nginx-proxy-manager@b4f49969d6/backend/internal/token.js (L131)

github.com/NginxProxyManager/nginx-proxy-manager@b4f49969d6/backend/internal/token.js (L159)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4338 **Author:** [@Sander0542](https://github.com/Sander0542) **Created:** 2/3/2025 **Status:** ✅ Merged **Merged:** 2/5/2025 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `fix/token-expires-type` --- ### 📝 Commits (1) - [`57cd2a1`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/57cd2a19198e7f7589529f477c4ed5dbfe1d26b5) Fix type for token.expires ### 📊 Changes **3 files changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/schema/components/token-object.json` (+3 -4) 📝 `backend/schema/paths/tokens/get.json` (+1 -1) 📝 `backend/schema/paths/tokens/post.json` (+1 -1) </details> ### 📄 Description Currently, the `token.expires` property is advertised as an interger in the api schema, but the API returns a ISO string. I updated the schema to match the actual API. https://github.com/NginxProxyManager/nginx-proxy-manager/blob/b4f49969d64c673acaa2f2a672f934ac84a66c5d/backend/internal/token.js#L70 https://github.com/NginxProxyManager/nginx-proxy-manager/blob/b4f49969d64c673acaa2f2a672f934ac84a66c5d/backend/internal/token.js#L131 https://github.com/NginxProxyManager/nginx-proxy-manager/blob/b4f49969d64c673acaa2f2a672f934ac84a66c5d/backend/internal/token.js#L159 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:32:14 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3863

No description provided.

Rows
Columns