[PR #4224] [CLOSED] Draft: Fixing CI issues? #3844

New issue

Closed

opened 2026-02-26 08:32:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:32:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4224
Author: @chutch1122
Created: 12/11/2024
Status: ❌ Closed

Base: develop ← Head: FEAT/open-id-connect-authentication

📝 Commits (10+)

caeb293 FEAT: Add Open ID Connect authentication method
3e2a411 chore: add oidc setting db entry during setup
457d1a7 chore: improve oidc setting ui
8350271 chore: add message texts
bc0b466 refactor: improve code structure
baee464 chore: improve error handling
6f98fa6 refactor: satisfy linter requirements
df5ab36 chore: update comments, remove debug logging
ef64edd fix: add database migration for oidc-config setting
fd49644 fix: linter

📊 Changes

26 files changed (+1527 additions, -1310 deletions)

View changed files

📝 backend/internal/token.js (+41 -0)
📝 backend/lib/express/jwt-decode.js (+8 -1)
📝 backend/logger.js (+2 -1)
📝 backend/package.json (+2 -1)
📝 backend/routes/main.js (+1 -0)
➕ backend/routes/oidc.js (+168 -0)
📝 backend/routes/settings.js (+12 -0)
📝 backend/routes/tokens.js (+2 -0)
📝 backend/schema/paths/settings/settingID/put.json (+57 -16)
📝 backend/setup.js (+50 -24)
📝 backend/yarn.lock (+544 -1250)
📝 docs/src/setup/index.md (+39 -0)
📝 frontend/js/app/api.js (+5 -0)
📝 frontend/js/app/controller.js (+5 -0)
📝 frontend/js/app/dashboard/main.ejs (+1 -1)
📝 frontend/js/app/settings/list/item.ejs (+22 -2)
➕ frontend/js/app/settings/oidc-config/main.ejs (+56 -0)
➕ frontend/js/app/settings/oidc-config/main.js (+46 -0)
📝 frontend/js/i18n/messages.json (+7 -1)
📝 frontend/js/login/ui/login.ejs (+12 -5)

...and 6 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4224 **Author:** [@chutch1122](https://github.com/chutch1122) **Created:** 12/11/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `FEAT/open-id-connect-authentication` --- ### 📝 Commits (10+) - [`caeb293`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/caeb2934f0dff0e6b7d73b9bbeddb74a2f31116d) FEAT: Add Open ID Connect authentication method - [`3e2a411`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/3e2a411dfbd53ca4be6c61a96fb0d322eff92cfc) chore: add oidc setting db entry during setup - [`457d1a7`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/457d1a75ba6124ec499a49433f3232f4ceeb1536) chore: improve oidc setting ui - [`8350271`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/8350271e6f83dd7c581d5d935b058df7be9828fb) chore: add message texts - [`bc0b466`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/bc0b466a8e79911022ce38937e0dc832154d5b47) refactor: improve code structure - [`baee464`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/baee4641db474ce15ba9d5a64d9265193ea708c6) chore: improve error handling - [`6f98fa6`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/6f98fa61e4991ed7b8bdbf177bea87c97c9238e0) refactor: satisfy linter requirements - [`df5ab36`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/df5ab361e30fae36cba8b4dd2b419a0911746b7a) chore: update comments, remove debug logging - [`ef64edd`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/ef64edd9432b05f39063f790188df495dca04c84) fix: add database migration for oidc-config setting - [`fd49644`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/fd49644f212399cb2f6c27e75fcd176fe1baa89f) fix: linter ### 📊 Changes **26 files changed** (+1527 additions, -1310 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/token.js` (+41 -0) 📝 `backend/lib/express/jwt-decode.js` (+8 -1) 📝 `backend/logger.js` (+2 -1) 📝 `backend/package.json` (+2 -1) 📝 `backend/routes/main.js` (+1 -0) ➕ `backend/routes/oidc.js` (+168 -0) 📝 `backend/routes/settings.js` (+12 -0) 📝 `backend/routes/tokens.js` (+2 -0) 📝 `backend/schema/paths/settings/settingID/put.json` (+57 -16) 📝 `backend/setup.js` (+50 -24) 📝 `backend/yarn.lock` (+544 -1250) 📝 `docs/src/setup/index.md` (+39 -0) 📝 `frontend/js/app/api.js` (+5 -0) 📝 `frontend/js/app/controller.js` (+5 -0) 📝 `frontend/js/app/dashboard/main.ejs` (+1 -1) 📝 `frontend/js/app/settings/list/item.ejs` (+22 -2) ➕ `frontend/js/app/settings/oidc-config/main.ejs` (+56 -0) ➕ `frontend/js/app/settings/oidc-config/main.js` (+46 -0) 📝 `frontend/js/i18n/messages.json` (+7 -1) 📝 `frontend/js/login/ui/login.ejs` (+12 -5) _...and 6 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:32:10 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3844

No description provided.

Rows
Columns