mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 09:25:55 +03:00
[PR #4127] Support for chaning the HTTP and HTTPS port that hosts will listen on #3824
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3824
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4127
Author: @snordmann
Created: 10/31/2024
Status: 🔄 Open
Base:
develop← Head:configurable-ports📝 Commits (4)
9844df2Support for chaning the HTTP and HTTPS port that hosts will listen onc377db5ups, forgot eslint8d0ed27Process folder /etc/nginx/conf.d for HTTP/HTTPS port migration2a9e573Adjust log message format📊 Changes
6 files changed (+127 additions, -9 deletions)
View changed files
📝
backend/internal/nginx.js(+44 -3)📝
backend/templates/_listen.conf(+6 -6)📝
docker/docker-compose.dev.yml(+2 -0)📝
docker/rootfs/etc/s6-overlay/s6-rc.d/prepare/00-all.sh(+1 -0)➕
docker/rootfs/etc/s6-overlay/s6-rc.d/prepare/55-http-https-port.sh(+62 -0)📝
docs/src/advanced-config/index.md(+12 -0)📄 Description
I have seen a few issues that mention that changing the port that nginx listens on is important (especially when using hostNetwork).
I am not totally convinced that NPM should allow these use-cases but I was bored enough to implement it anyway.
Related Issue: #4122
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.