[PR #3392] [MERGED] Make auto-renew use built-in renew function #3694

New issue

Closed

opened 2026-02-26 08:31:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:31:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3392
Author: @stevecrozz
Created: 12/15/2023
Status: ✅ Merged
Merged: 1/12/2024
Merged by: @jc21

Base: develop ← Head: auto-renew-uses-bulitin-renew

📝 Commits (3)

fe4bd9f Make auto-renew use built-in renew function
f7d1c49 Run renews sequentially
9c54d1b Provide the token model for certificate renewal

📊 Changes

1 file changed (+46 additions, -55 deletions)

View changed files

📝 backend/internal/certificate.js (+46 -55)

📄 Description

As a complete newcomer to this project, this is my attempt to fix certificate auto-renew issues #1916 where manual renew works, but automatic renew does not. This changes proposes we replace the functionality inside automatic renewal with a call to the same function used for manual renewal.

Specifically, I have replaced the certbot 'renew everything' command with a DB-driven one-by-one renewal. Determining which certificates need renewal is a pretty naive time based DB query, and access control is completely bypassed with Promise.resolve({ permission_visibility: 'all' } because I assume it isn't needed for a background job.

I'm not sure yet how to best contribute to this project, and I'm sure there are some issues with this so please do guide me as I'm brand new here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3392 **Author:** [@stevecrozz](https://github.com/stevecrozz) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 1/12/2024 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `auto-renew-uses-bulitin-renew` --- ### 📝 Commits (3) - [`fe4bd9f`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/fe4bd9fed6da28b4a30e8ef28dd1e09f11537bb9) Make auto-renew use built-in renew function - [`f7d1c49`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/f7d1c490b38449d8148ac01783ca467d90181a00) Run renews sequentially - [`9c54d1b`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/9c54d1b7184bad39d364b70a34c91fa9e612f17b) Provide the token model for certificate renewal ### 📊 Changes **1 file changed** (+46 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/certificate.js` (+46 -55) </details> ### 📄 Description As a complete newcomer to this project, this is my attempt to fix certificate auto-renew issues #1916 where manual renew works, but automatic renew does not. This changes proposes we replace the functionality inside automatic renewal with a call to the same function used for manual renewal. Specifically, I have replaced the certbot 'renew everything' command with a DB-driven one-by-one renewal. Determining which certificates need renewal is a pretty naive time based DB query, and access control is completely bypassed with `Promise.resolve({ permission_visibility: 'all' }` because I assume it isn't needed for a background job. I'm not sure yet how to best contribute to this project, and I'm sure there are some issues with this so please do guide me as I'm brand new here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:31:36 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3694

No description provided.

Rows
Columns