[PR #3388] [MERGED] Fixes for the server reachability test. #3693

Closed
opened 2026-02-26 08:31:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3388
Author: @jlesage
Created: 12/14/2023
Status: Merged
Merged: 1/8/2024
Merged by: @jc21

Base: developHead: reachability-test-fix


📝 Commits (1)

  • 388fff8 Fixes for the server reachability test.

📊 Changes

2 files changed (+25 additions, -4 deletions)

View changed files

📝 backend/internal/certificate.js (+18 -4)
📝 docker/rootfs/etc/nginx/conf.d/include/force-ssl.conf (+7 -0)

📄 Description

  • Do not apply HTTPs redirection for challenge used by the test.
  • Set the User-Agent to avoid 403 answer from site24x7.com.
  • Handle JSON parsing failure of the received body.
  • Better handling of different error cases.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3388 **Author:** [@jlesage](https://github.com/jlesage) **Created:** 12/14/2023 **Status:** ✅ Merged **Merged:** 1/8/2024 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `reachability-test-fix` --- ### 📝 Commits (1) - [`388fff8`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/388fff84f2b9fb68fb6b2bacf940bbf7faef675d) Fixes for the server reachability test. ### 📊 Changes **2 files changed** (+25 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/certificate.js` (+18 -4) 📝 `docker/rootfs/etc/nginx/conf.d/include/force-ssl.conf` (+7 -0) </details> ### 📄 Description - Do not apply HTTPs redirection for challenge used by the test. - Set the `User-Agent` to avoid 403 answer from site24x7.com. - Handle JSON parsing failure of the received body. - Better handling of different error cases. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 08:31:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3693
No description provided.