[PR #3331] [CLOSED] Ssl passthrough hosts - updated #3683

Closed
opened 2026-02-26 08:31:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3331
Author: @acul009
Created: 11/17/2023
Status: Closed

Base: developHead: ssl-passthrough-hosts


📝 Commits (10+)

  • 66cbd12 WIP: started adding new host type ssl passthrough
  • b44dcd4 WIP: complete control of new passthrough host type
  • b9ab4a2 Finalizes SSL Passthrough hosts
  • c6a50e0 Fixes eslint errors
  • 040f4a7 Adds comments to docker compose dev
  • 48aac78 Fixes migration
  • c5b9752 compose file fix
  • c91084b fixed broken syntax and padding
  • 676db1c fixed padding and syntax
  • 467f4ab fixed remove functions

📊 Changes

40 files changed (+1932 additions, -119 deletions)

View changed files

📝 backend/internal/host.js (+35 -7)
📝 backend/internal/nginx.js (+153 -63)
backend/internal/ssl-passthrough-host.js (+357 -0)
📝 backend/internal/user.js (+9 -8)
backend/lib/access/ssl_passthrough_hosts-create.json (+23 -0)
backend/lib/access/ssl_passthrough_hosts-delete.json (+23 -0)
backend/lib/access/ssl_passthrough_hosts-get.json (+23 -0)
backend/lib/access/ssl_passthrough_hosts-list.json (+23 -0)
backend/lib/access/ssl_passthrough_hosts-update.json (+23 -0)
backend/migrations/20211010141200_ssl_passthrough_host.js (+85 -0)
backend/models/ssl_passthrough_host.js (+55 -0)
📝 backend/routes/api/main.js (+12 -3)
backend/routes/api/nginx/ssl_passthrough_hosts.js (+196 -0)
backend/schema/endpoints/ssl-passthrough-hosts.json (+208 -0)
📝 backend/schema/index.json (+3 -0)
📝 backend/setup.js (+31 -18)
backend/templates/ssl_passthrough_host.conf (+41 -0)
📝 docker/docker-compose.dev.yml (+3 -1)
📝 docker/rootfs/etc/nginx/nginx.conf (+1 -0)
📝 docker/rootfs/etc/s6-overlay/s6-rc.d/prepare/20-paths.sh (+1 -0)

...and 20 more files

📄 Description

Hi,

This PR updates the original Request: SSL passthrough hosts #1479

My use case is passing data to hosts which can handle certificate request for themselves.
In those cases I'd use the http proxy to only forward the requests to /.well-known/acme-challenge.

Additional traffic then has to arrive over TLS to work.
This makes reusing Port 443 for multiple services a breeze.

@chaptergy If you have some time, I'd really appreciate if you could check that I didn't botch any of your work :)

This would resolve Ticket #853 and allow for more secure data handling inside local networks.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3331 **Author:** [@acul009](https://github.com/acul009) **Created:** 11/17/2023 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `ssl-passthrough-hosts` --- ### 📝 Commits (10+) - [`66cbd12`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/66cbd1239f60c1dfe5ddf78c4275034e4e238907) WIP: started adding new host type ssl passthrough - [`b44dcd4`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/b44dcd48b9fb006efe904bd329540fe54181c953) WIP: complete control of new passthrough host type - [`b9ab4a2`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/b9ab4a2dca4e2e039ffa3830127bb58f48cf3df8) Finalizes SSL Passthrough hosts - [`c6a50e0`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c6a50e05610ea8e5a4ad748f5be6c05153eff6ad) Fixes eslint errors - [`040f4a7`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/040f4a76dd51a69981ae7fe58b8d24ed21f00aeb) Adds comments to docker compose dev - [`48aac78`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/48aac7803dae65dd54aac0721c43c192ba9d62cd) Fixes migration - [`c5b9752`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c5b975287f011de87433a1b85153bf2170fc7fb1) compose file fix - [`c91084b`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c91084b956154787beae1149762e5d0a7dc1a480) fixed broken syntax and padding - [`676db1c`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/676db1cac1cbed0288892ab956cbdc24e4f0418f) fixed padding and syntax - [`467f4ab`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/467f4ab83316ae9424dc8a1ed5ad0b697d136990) fixed remove functions ### 📊 Changes **40 files changed** (+1932 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/host.js` (+35 -7) 📝 `backend/internal/nginx.js` (+153 -63) ➕ `backend/internal/ssl-passthrough-host.js` (+357 -0) 📝 `backend/internal/user.js` (+9 -8) ➕ `backend/lib/access/ssl_passthrough_hosts-create.json` (+23 -0) ➕ `backend/lib/access/ssl_passthrough_hosts-delete.json` (+23 -0) ➕ `backend/lib/access/ssl_passthrough_hosts-get.json` (+23 -0) ➕ `backend/lib/access/ssl_passthrough_hosts-list.json` (+23 -0) ➕ `backend/lib/access/ssl_passthrough_hosts-update.json` (+23 -0) ➕ `backend/migrations/20211010141200_ssl_passthrough_host.js` (+85 -0) ➕ `backend/models/ssl_passthrough_host.js` (+55 -0) 📝 `backend/routes/api/main.js` (+12 -3) ➕ `backend/routes/api/nginx/ssl_passthrough_hosts.js` (+196 -0) ➕ `backend/schema/endpoints/ssl-passthrough-hosts.json` (+208 -0) 📝 `backend/schema/index.json` (+3 -0) 📝 `backend/setup.js` (+31 -18) ➕ `backend/templates/ssl_passthrough_host.conf` (+41 -0) 📝 `docker/docker-compose.dev.yml` (+3 -1) 📝 `docker/rootfs/etc/nginx/nginx.conf` (+1 -0) 📝 `docker/rootfs/etc/s6-overlay/s6-rc.d/prepare/20-paths.sh` (+1 -0) _...and 20 more files_ </details> ### 📄 Description Hi, This PR updates the original Request: [SSL passthrough hosts #1479](https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1479) My use case is passing data to hosts which can handle certificate request for themselves. In those cases I'd use the http proxy to only forward the requests to /.well-known/acme-challenge. Additional traffic then has to arrive over TLS to work. This makes reusing Port 443 for multiple services a breeze. @chaptergy If you have some time, I'd really appreciate if you could check that I didn't botch any of your work :) This would resolve Ticket #853 and allow for more secure data handling inside local networks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 08:31:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3683
No description provided.