[PR #2530] [MERGED] ACL changes should not blow away cert config #3584

New issue

Closed

opened 2026-02-26 08:31:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:31:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/2530
Author: @jmerdich
Created: 1/10/2023
Status: ✅ Merged
Merged: 3/8/2023
Merged by: @jc21

Base: develop ← Head: jmerdich/fix-acl-edit-ssl

📝 Commits (1)

c80d099 ACL changes should not blow away cert config

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 backend/internal/access-list.js (+2 -2)

📄 Description

When editing an access list, all affected sites get their config updated without certificates, functionally breaking https on those sites until they get a manual config change that rewrites the config properly. Properly fetch the certificate from the DB before bulkGenerateConfigs so it gets updated right.

I am not certain whether there are similar bugs in other places that use bulkGenerateConfigs.

Should fix #2254

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/2530 **Author:** [@jmerdich](https://github.com/jmerdich) **Created:** 1/10/2023 **Status:** ✅ Merged **Merged:** 3/8/2023 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `jmerdich/fix-acl-edit-ssl` --- ### 📝 Commits (1) - [`c80d099`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c80d099193115bd760e2bfa39f95e32fa49883a3) ACL changes should not blow away cert config ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/access-list.js` (+2 -2) </details> ### 📄 Description When editing an access list, all affected sites get their config updated without certificates, functionally breaking https on those sites until they get a manual config change that rewrites the config properly. Properly fetch the certificate from the DB before `bulkGenerateConfigs` so it gets updated right. I am not certain whether there are similar bugs in other places that use `bulkGenerateConfigs`. Should fix #2254 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:31:11 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 08:31:43 +03:00

[PR #3584] [MERGED] Access-List fix so that nginx config is loaded after configuration happens #3727

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3584

No description provided.

Rows
Columns