[PR #2444] [MERGED] Load events configuration from custom file #3568

New issue

Closed

opened 2026-02-26 08:31:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:31:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/2444
Author: @Blooym
Created: 12/2/2022
Status: ✅ Merged
Merged: 3/8/2023
Merged by: @jc21

Base: develop ← Head: develop

📝 Commits (1)

3c23aa9 Load events configuration from custom file

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 docker/rootfs/etc/nginx/nginx.conf (+1 -1)
📝 docs/advanced-config/README.md (+1 -0)

📄 Description

Changes

Instead of forcing users to mount a custom nginx.conf file to modify the events configuration, we should instead allow them to use a /custom/events.conf file to modify it, as is standard for other advanced parts of NPMs configuration. It also reverts the default worker_connections amount to NGINX's default to prevent duplicate key issues if a user wants to set a custom worker_connections amount.

Rationale

I was consistently running into issues when using NPM as I was unable to modify my worker_connections amount without some hacky workarounds, so I wanted to make it as easy as changing other parts of the configuration.

Additional Information

Let me know if anything in this PR needs adjusting, I am by no means an NGINX expert and just wanted to upstream some of my local changes. If this is unwanted, feel free to just close the PR.

Linked Issues

Fixes #1435, #1912, #2388

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/2444 **Author:** [@Blooym](https://github.com/Blooym) **Created:** 12/2/2022 **Status:** ✅ Merged **Merged:** 3/8/2023 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`3c23aa9`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/3c23aa935e1956b0f7219b649f7e02bbfd67e938) Load events configuration from custom file ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docker/rootfs/etc/nginx/nginx.conf` (+1 -1) 📝 `docs/advanced-config/README.md` (+1 -0) </details> ### 📄 Description ## Changes Instead of forcing users to mount a custom `nginx.conf` file to modify the **events** configuration, we should instead allow them to use a `/custom/events.conf` file to modify it, as is standard for other advanced parts of NPMs configuration. It also reverts the default `worker_connections` amount to NGINX's default to prevent duplicate key issues if a user wants to set a custom `worker_connections` amount. ## Rationale I was consistently running into issues when using NPM as I was unable to modify my worker_connections amount without some hacky workarounds, so I wanted to make it as easy as changing other parts of the configuration. ## Additional Information Let me know if anything in this PR needs adjusting, I am by no means an NGINX expert and just wanted to upstream some of my local changes. If this is unwanted, feel free to just close the PR. ## Linked Issues Fixes #1435, #1912, #2388 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:31:08 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3568

No description provided.

Rows
Columns