[PR #1921] [CLOSED] removing HSTS include from location as it is superfluous. #3507

New issue

Closed

opened 2026-02-26 08:30:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:30:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1921
Author: @ncraig-oc
Created: 3/9/2022
Status: ❌ Closed

Base: develop ← Head: hsts_to_serverdef

📝 Commits (10+)

9c3e024 removing HSTS include from location as it is superfluous. HSTS is defined at the server level and re-adding the host at the location prevents inheritance from the advanced config include.
7f2d59a Merge branch 'NginxProxyManager:develop' into develop
9a4952d Merge pull request #1 from ncraig-oc/develop
c571599 adding wrapper for proxy header passing.
f31692d Merge pull request #2 from ncraig-oc/develop
30c9a1f converting to AWS image
2f8097c removing HSTS include from location as it is superfluous.
6368c39 merging changes
e826294 commiting OC AWS tools
469ecad missing updates.

📊 Changes

17 files changed (+261 additions, -25 deletions)

View changed files

📝 Jenkinsfile (+3 -3)
➕ aws/cloud-formation/template.yml (+137 -0)
📝 backend/templates/dead_host.conf (+5 -2)
📝 backend/templates/proxy_host.conf (+20 -4)
📝 backend/templates/redirection_host.conf (+3 -4)
➕ deploy_build.sh (+39 -0)
➕ deploy_fargate.sh (+1 -0)
📝 docker/Dockerfile (+7 -5)
📝 docker/rootfs/etc/nginx/conf.d/include/proxy.conf (+1 -4)
📝 docker/rootfs/etc/nginx/nginx.conf (+2 -1)
📝 docker/rootfs/etc/s6-overlay/s6-rc.d/prepare/60-secrets.sh (+0 -0)
📝 docker/scripts/install-s6 (+0 -0)
📝 frontend/js/models/proxy-host.js (+1 -0)
📝 frontend/package.json (+1 -1)
📝 frontend/scss/tabler-extra.scss (+4 -0)
➕ local_build.sh (+35 -0)
📝 scripts/ci/frontend-build (+2 -1)

📄 Description

HSTS is defined at the server level and re-adding the host at the location prevents inheritance from the advanced config include.

Per the NGINX documentation,
"These directives are inherited from the previous configuration level if and only if there are no add_header directives defined on the current level."

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1921 **Author:** [@ncraig-oc](https://github.com/ncraig-oc) **Created:** 3/9/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `hsts_to_serverdef` --- ### 📝 Commits (10+) - [`9c3e024`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/9c3e0242873d1ae5cc647d88ec25860166f20eea) removing HSTS include from location as it is superfluous. HSTS is defined at the server level and re-adding the host at the location prevents inheritance from the advanced config include. - [`7f2d59a`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/7f2d59a4f137fe6116107c36d559ad3218784331) Merge branch 'NginxProxyManager:develop' into develop - [`9a4952d`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/9a4952db640eb2a154ecbeab050b5e0e8e38ae59) Merge pull request #1 from ncraig-oc/develop - [`c571599`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c571599d45cf037f9f08b771278f8af5ee8c37e7) adding wrapper for proxy header passing. - [`f31692d`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/f31692dbcb434d526f40e99f8ee368c8568e7441) Merge pull request #2 from ncraig-oc/develop - [`30c9a1f`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/30c9a1fbbdb7c342ab8722e636b3f288ee48f4d8) converting to AWS image - [`2f8097c`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/2f8097cdd4bc8def3ae65d7971fd312289266010) removing HSTS include from location as it is superfluous. - [`6368c39`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/6368c39ef72bb6ed0e19f178571211106fdb6ad8) merging changes - [`e826294`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/e8262946d70cf72237643424b9856da6f46941ea) commiting OC AWS tools - [`469ecad`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/469ecadbbbbcbe1144c8e45b3283d3f60a1b701f) missing updates. ### 📊 Changes **17 files changed** (+261 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `Jenkinsfile` (+3 -3) ➕ `aws/cloud-formation/template.yml` (+137 -0) 📝 `backend/templates/dead_host.conf` (+5 -2) 📝 `backend/templates/proxy_host.conf` (+20 -4) 📝 `backend/templates/redirection_host.conf` (+3 -4) ➕ `deploy_build.sh` (+39 -0) ➕ `deploy_fargate.sh` (+1 -0) 📝 `docker/Dockerfile` (+7 -5) 📝 `docker/rootfs/etc/nginx/conf.d/include/proxy.conf` (+1 -4) 📝 `docker/rootfs/etc/nginx/nginx.conf` (+2 -1) 📝 `docker/rootfs/etc/s6-overlay/s6-rc.d/prepare/60-secrets.sh` (+0 -0) 📝 `docker/scripts/install-s6` (+0 -0) 📝 `frontend/js/models/proxy-host.js` (+1 -0) 📝 `frontend/package.json` (+1 -1) 📝 `frontend/scss/tabler-extra.scss` (+4 -0) ➕ `local_build.sh` (+35 -0) 📝 `scripts/ci/frontend-build` (+2 -1) </details> ### 📄 Description HSTS is defined at the server level and re-adding the host at the location prevents inheritance from the advanced config include. Per the NGINX documentation, "These directives are inherited from the previous configuration level if and only if there are no add_header directives defined on the current level." --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:30:54 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3507

No description provided.

Rows
Columns