[PR #1882] PROXY Protocol support #3500

Open
opened 2026-02-26 08:30:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1882
Author: @SBado
Created: 2/23/2022
Status: 🔄 Open

Base: developHead: develop


📝 Commits (7)

  • b687548 Merge pull request 'Fork syncthing' (#1) from GitHub/nginx-proxy-manager:develop into develop
  • ecb2752 PROXY Protocol support implementation
  • 9eabfb9 Merge branch 'NginxProxyManager:develop' into develop
  • 6c5f198 Merge branch 'develop' into develop
  • 54864f4 Merge branch 'NginxProxyManager:develop' into develop
  • cc6d249 Merge branch 'NginxProxyManager:develop' into develop
  • 1eb6a57 Merge branch 'NginxProxyManager:develop' into develop

📊 Changes

10 files changed (+123 additions, -10 deletions)

View changed files

📝 backend/internal/nginx.js (+2 -1)
backend/migrations/20220209144645_proxy_protocol.js (+36 -0)
📝 backend/schema/endpoints/proxy-hosts.json (+28 -0)
📝 backend/templates/_listen.conf (+15 -5)
backend/templates/_proxy_protocol.conf (+6 -0)
📝 backend/templates/proxy_host.conf (+1 -0)
📝 frontend/js/app/nginx/proxy/form.ejs (+16 -1)
📝 frontend/js/app/nginx/proxy/form.js (+13 -1)
📝 frontend/js/i18n/messages.json (+4 -2)
📝 frontend/js/models/proxy-host.js (+2 -0)

📄 Description

This PR add basic support for PROXY protocol to NPM. I needed NPM to support PROXY protocol becasue I'm using two instances of HAProxy as a point of access to my services, as described here. It's been working fine for me so far, so I thought to share.

Note: to allow coexistence of "regular" and "PROXY protocol enabled" hosts, the latter ones will listen on port 88 and 444.

Related issue: #1114.

immagine


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1882 **Author:** [@SBado](https://github.com/SBado) **Created:** 2/23/2022 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (7) - [`b687548`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/b6875487fd69f4c096ee32d3eb3e7ce4edb282c4) Merge pull request 'Fork syncthing' (#1) from GitHub/nginx-proxy-manager:develop into develop - [`ecb2752`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/ecb27521b411339d7cf9e9652d37b3e8174ed26c) PROXY Protocol support implementation - [`9eabfb9`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/9eabfb9a535741ca0559633751bbb212e9cbde11) Merge branch 'NginxProxyManager:develop' into develop - [`6c5f198`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/6c5f1988f06126da89fae0ec25c046b479adebfb) Merge branch 'develop' into develop - [`54864f4`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/54864f48516b34991862497391aaac85af319ba5) Merge branch 'NginxProxyManager:develop' into develop - [`cc6d249`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/cc6d249bb7380cc2efe3890636950a81826c11ac) Merge branch 'NginxProxyManager:develop' into develop - [`1eb6a57`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/1eb6a577402c57efefb5ef541cbbac78177bef5a) Merge branch 'NginxProxyManager:develop' into develop ### 📊 Changes **10 files changed** (+123 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/nginx.js` (+2 -1) ➕ `backend/migrations/20220209144645_proxy_protocol.js` (+36 -0) 📝 `backend/schema/endpoints/proxy-hosts.json` (+28 -0) 📝 `backend/templates/_listen.conf` (+15 -5) ➕ `backend/templates/_proxy_protocol.conf` (+6 -0) 📝 `backend/templates/proxy_host.conf` (+1 -0) 📝 `frontend/js/app/nginx/proxy/form.ejs` (+16 -1) 📝 `frontend/js/app/nginx/proxy/form.js` (+13 -1) 📝 `frontend/js/i18n/messages.json` (+4 -2) 📝 `frontend/js/models/proxy-host.js` (+2 -0) </details> ### 📄 Description This PR add basic support for [PROXY protocol](https://docs.nginx.com/nginx/admin-guide/load-balancer/using-proxy-protocol) to NPM. I needed NPM to support PROXY protocol becasue I'm using two instances of HAProxy as a point of access to my services, as described [here](https://theorangeone.net/posts/server-2020-proxmox/#ingress). It's been working fine for me so far, so I thought to share. Note: to allow coexistence of "regular" and "PROXY protocol enabled" hosts, the latter ones will listen on port 88 and 444. Related issue: #1114. ![immagine](https://user-images.githubusercontent.com/16034687/155310610-a666fccd-fd09-4c9e-946c-c8e7fc4122cb.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3500
No description provided.