mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 09:25:55 +03:00
[PR #1614] [MERGED] Feature: Add two new headers to proxy.conf #3466
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3466
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1614
Author: @the1ts
Created: 11/29/2021
Status: ✅ Merged
Merged: 1/2/2022
Merged by: @jc21
Base:
develop← Head:feature/proxy-header-additions📝 Commits (5)
3dfe238Add two new headers to proxy.conf2ac1026Hack for python binary in newer node images5d106c4Bump versionab80fe1Fixes custom certificate upload modal7800938Update default.conf📊 Changes
6 files changed (+12 additions, -8 deletions)
View changed files
📝
.version(+1 -1)📝
Jenkinsfile(+1 -1)📝
README.md(+1 -1)📝
backend/templates/default.conf(+2 -2)📝
docker/rootfs/etc/nginx/conf.d/include/proxy.conf(+2 -0)📝
frontend/js/app/nginx/certificates/form.js(+5 -3)📄 Description
Fixes #1609. Adding both X-Forwarded-Host and X-Forwarded-Port, this is vital for some services behind a proxy (used to allow creation of absolute links in html). I've had to include at least the Host version in the past for Jenkins and Nexus.
Been running locally for 24 hours, does not appear to break any of my 15+ services currently running behind NPM would allow people to host those problem services without the need for advanced configuration.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.