[PR #1578] [MERGED] Reverts back to proxy_pass without variables #3462

New issue

Closed

opened 2026-02-26 08:30:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:30:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1578
Author: @chaptergy
Created: 11/9/2021
Status: ✅ Merged
Merged: 11/9/2021
Merged by: @jc21

Base: develop ← Head: undo-switch-to-variables

📝 Commits (1)

1f879f6 Reverts back to proxy_pass without variables

📊 Changes

2 files changed (+2 additions, -9 deletions)

View changed files

📝 backend/templates/_location.conf (+1 -7)
📝 docker/rootfs/etc/nginx/conf.d/include/proxy.conf (+1 -2)

📄 Description

So apparently using the variable for the proxy_pass directive comes with a whole load of issues which are not easily fixable, and break how locations are expected to work. This reverts the template back to the normal proxy_pass usage without storing the target in a variable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1578 **Author:** [@chaptergy](https://github.com/chaptergy) **Created:** 11/9/2021 **Status:** ✅ Merged **Merged:** 11/9/2021 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `undo-switch-to-variables` --- ### 📝 Commits (1) - [`1f879f6`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/1f879f67a9bed8f5eb444d00ad47c353b8a75db8) Reverts back to proxy_pass without variables ### 📊 Changes **2 files changed** (+2 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/templates/_location.conf` (+1 -7) 📝 `docker/rootfs/etc/nginx/conf.d/include/proxy.conf` (+1 -2) </details> ### 📄 Description So apparently using the variable for the `proxy_pass` directive comes with a whole load of issues which are not easily fixable, and break how locations are expected to work. This reverts the template back to the normal `proxy_pass` usage without storing the target in a variable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:30:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3462

No description provided.

Rows
Columns