mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-26 09:55:51 +03:00
[PR #1479] SSL passthrough hosts #3440
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3440
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1479
Author: @chaptergy
Created: 10/12/2021
Status: 🔄 Open
Base:
develop← Head:ssl-passthrough-hosts📝 Commits (7)
5b1f0ceWIP: started adding new host type ssl passthrough5a2548cWIP: complete control of new passthrough host typeab026e5Merge branch 'develop'02d3093Finalizes SSL Passthrough hostsf650137Fixes eslint errors6e82161Adds comments to docker compose dev70163a6Fixes migration📊 Changes
41 files changed (+1949 additions, -129 deletions)
View changed files
📝
backend/app.js(+4 -6)📝
backend/internal/host.js(+35 -7)📝
backend/internal/nginx.js(+155 -64)➕
backend/internal/ssl-passthrough-host.js(+365 -0)📝
backend/internal/user.js(+9 -8)➕
backend/lib/access/ssl_passthrough_hosts-create.json(+23 -0)➕
backend/lib/access/ssl_passthrough_hosts-delete.json(+23 -0)➕
backend/lib/access/ssl_passthrough_hosts-get.json(+23 -0)➕
backend/lib/access/ssl_passthrough_hosts-list.json(+23 -0)➕
backend/lib/access/ssl_passthrough_hosts-update.json(+23 -0)➕
backend/migrations/20211010141200_ssl_passthrough_host.js(+85 -0)➕
backend/models/ssl_passthrough_host.js(+56 -0)📝
backend/routes/api/main.js(+12 -3)➕
backend/routes/api/nginx/ssl_passthrough_hosts.js(+196 -0)➕
backend/schema/endpoints/ssl-passthrough-hosts.json(+208 -0)📝
backend/schema/index.json(+3 -0)📝
backend/setup.js(+33 -21)➕
backend/templates/ssl_passthrough_host.conf(+41 -0)📝
docker/docker-compose.dev.yml(+5 -1)📝
docker/rootfs/etc/nginx/nginx.conf(+1 -0)...and 21 more files
📄 Description
This PR would resolve https://github.com/jc21/nginx-proxy-manager/issues/853.
SSL passthrough would be a new type of host where the ssl certificate of the upstream server is used, so no ssl termination is done at the proxy. But the only way this is possible in nginx is streams, using SNI to forward the packet to the right destination. As a stream and the normal proxies using http cannot be on the same port, all https traffic has to go through the stream, which then could forward it internally to the http proxy. As this reduces performance for all hosts, this feature is strictly opt-in. The documentation was updated to add a section about this to the advanced config page.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.