[PR #1286] [MERGED] Fixes certificate renewal #3408

New issue

Closed

opened 2026-02-26 08:30:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:30:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1286
Author: @chaptergy
Created: 8/4/2021
Status: ✅ Merged
Merged: 8/7/2021
Merged by: @jc21

Base: develop ← Head: fixes-certificate-renewal

📝 Commits (3)

cea80b4 Fixes certificate renewal for dns challenges
d346911 Fixes renewal unused http certificates
83c5c55 Fixes creation of certificates using the http challenge

📊 Changes

4 files changed (+6 additions, -2 deletions)

View changed files

📝 backend/internal/certificate.js (+2 -0)
📝 backend/templates/default.conf (+2 -0)
📝 docker/rootfs/etc/letsencrypt.ini (+0 -1)
📝 docker/rootfs/etc/nginx/conf.d/default.conf (+2 -1)

📄 Description

This will fix the certificate renewal in some cases:

Automatic renewal using DNS challenges used to always fail due to the authenticator being overwritten globally
Automatic renewal using the HTTP challenge used to fail if the domain was not used in any host.

This PR removes the global authenticator being set, since it is always set certificate specific as well, and adds the letsencrypt challenge functionality to the default host (using any of the congratulations site, 404 page, redirect or custom page)

Should fix https://github.com/jc21/nginx-proxy-manager/issues/1282, probably fixes https://github.com/jc21/nginx-proxy-manager/issues/1220, fixes https://github.com/jc21/nginx-proxy-manager/issues/1031, should fix https://github.com/jc21/nginx-proxy-manager/issues/1018 and fixes https://github.com/jc21/nginx-proxy-manager/issues/860

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1286 **Author:** [@chaptergy](https://github.com/chaptergy) **Created:** 8/4/2021 **Status:** ✅ Merged **Merged:** 8/7/2021 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `fixes-certificate-renewal` --- ### 📝 Commits (3) - [`cea80b4`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/cea80b482ebc5848d7246e7a74f2557384750070) Fixes certificate renewal for dns challenges - [`d346911`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/d34691152ca5efd93087a343d423fadcd6e06989) Fixes renewal unused http certificates - [`83c5c55`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/83c5c55f32be3792330ba860c77273a84e247628) Fixes creation of certificates using the http challenge ### 📊 Changes **4 files changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/certificate.js` (+2 -0) 📝 `backend/templates/default.conf` (+2 -0) 📝 `docker/rootfs/etc/letsencrypt.ini` (+0 -1) 📝 `docker/rootfs/etc/nginx/conf.d/default.conf` (+2 -1) </details> ### 📄 Description This will fix the certificate renewal in some cases: - Automatic renewal using DNS challenges used to always fail due to the authenticator being overwritten globally - Automatic renewal using the HTTP challenge used to fail if the domain was not used in any host. This PR removes the global authenticator being set, since it is always set certificate specific as well, and adds the letsencrypt challenge functionality to the default host (using any of the congratulations site, 404 page, redirect or custom page) Should fix https://github.com/jc21/nginx-proxy-manager/issues/1282, probably fixes https://github.com/jc21/nginx-proxy-manager/issues/1220, fixes https://github.com/jc21/nginx-proxy-manager/issues/1031, should fix https://github.com/jc21/nginx-proxy-manager/issues/1018 and fixes https://github.com/jc21/nginx-proxy-manager/issues/860 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:30:32 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 08:31:37 +03:00

[PR #3408] [MERGED] Add support for certbot-dns-plesk #3699

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3408

No description provided.

Rows
Columns