[PR #1265] [MERGED] Update letsencrypt.ini to support ECDSA keys #3406

Closed
opened 2026-02-26 08:30:32 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1265
Author: @phantomski77
Created: 7/28/2021
Status: Merged
Merged: 8/7/2021
Merged by: @jc21

Base: masterHead: master


📝 Commits (1)

  • c460a8f Update letsencrypt.ini to support ECDSA keys

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 docker/rootfs/etc/letsencrypt.ini (+2 -0)

📄 Description

Since we have newer certbot (1.10+) available (thanks!), it's time to support more modern, safer and efficient ECDSA private keys algorithms instead of RSA for the generated certificates. EC secp384r1 would need 7680bit RSA equivalent for comparable security with significantly higher overhead.

These should be now widely supported by all modern browsers and service clients. The only risk would be sudden certbot downgrade, which can be controlled.

I propose this should be now default.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1265 **Author:** [@phantomski77](https://github.com/phantomski77) **Created:** 7/28/2021 **Status:** ✅ Merged **Merged:** 8/7/2021 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`c460a8f`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c460a8fa5cd348513f650cdfa07792e4b5939414) Update letsencrypt.ini to support ECDSA keys ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docker/rootfs/etc/letsencrypt.ini` (+2 -0) </details> ### 📄 Description Since we have newer certbot (1.10+) available (thanks!), it's time to support more modern, safer and efficient ECDSA private keys algorithms instead of RSA for the generated certificates. EC secp384r1 would need 7680bit RSA equivalent for comparable security with significantly higher overhead. These should be now widely supported by all modern browsers and service clients. The only risk would be sudden certbot downgrade, which can be controlled. I propose this should be now default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 08:30:32 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3406
No description provided.