mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-26 01:45:54 +03:00
[PR #1265] [MERGED] Update letsencrypt.ini to support ECDSA keys #3406
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3406
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1265
Author: @phantomski77
Created: 7/28/2021
Status: ✅ Merged
Merged: 8/7/2021
Merged by: @jc21
Base:
master← Head:master📝 Commits (1)
c460a8fUpdate letsencrypt.ini to support ECDSA keys📊 Changes
1 file changed (+2 additions, -0 deletions)
View changed files
📝
docker/rootfs/etc/letsencrypt.ini(+2 -0)📄 Description
Since we have newer certbot (1.10+) available (thanks!), it's time to support more modern, safer and efficient ECDSA private keys algorithms instead of RSA for the generated certificates. EC secp384r1 would need 7680bit RSA equivalent for comparable security with significantly higher overhead.
These should be now widely supported by all modern browsers and service clients. The only risk would be sudden certbot downgrade, which can be controlled.
I propose this should be now default.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.