mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 09:25:55 +03:00
[PR #1255] [MERGED] Fixes crash when logrotate fails #3403
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3403
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1255
Author: @chaptergy
Created: 7/22/2021
Status: ✅ Merged
Merged: 7/23/2021
Merged by: @jc21
Base:
develop← Head:fixes-crash-when-logrotation-fails📝 Commits (2)
67e8ca6Fixes crash when logrotate failsfbae107Changes owner of logs to root on every container start📊 Changes
2 files changed (+8 additions, -2 deletions)
View changed files
📝
backend/setup.js(+4 -2)➕
docker/rootfs/etc/cont-init.d/01_perms.sh(+4 -0)📄 Description
Fixes https://github.com/jc21/nginx-proxy-manager/issues/1250
Somehow the owner of the logs is sometimes not root, which causes logrotate to fail. This makes sure that a failing of logrotate does not crash npm.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.