[PR #1255] [MERGED] Fixes crash when logrotate fails #3403

Closed
opened 2026-02-26 08:30:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1255
Author: @chaptergy
Created: 7/22/2021
Status: Merged
Merged: 7/23/2021
Merged by: @jc21

Base: developHead: fixes-crash-when-logrotation-fails


📝 Commits (2)

  • 67e8ca6 Fixes crash when logrotate fails
  • fbae107 Changes owner of logs to root on every container start

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 backend/setup.js (+4 -2)
docker/rootfs/etc/cont-init.d/01_perms.sh (+4 -0)

📄 Description

Fixes https://github.com/jc21/nginx-proxy-manager/issues/1250
Somehow the owner of the logs is sometimes not root, which causes logrotate to fail. This makes sure that a failing of logrotate does not crash npm.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1255 **Author:** [@chaptergy](https://github.com/chaptergy) **Created:** 7/22/2021 **Status:** ✅ Merged **Merged:** 7/23/2021 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `fixes-crash-when-logrotation-fails` --- ### 📝 Commits (2) - [`67e8ca6`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/67e8ca6714622276efa5c12383142745b6020f85) Fixes crash when logrotate fails - [`fbae107`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/fbae107c04e1ea11c358433ca68ad7e8718c5cec) Changes owner of logs to root on every container start ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/setup.js` (+4 -2) ➕ `docker/rootfs/etc/cont-init.d/01_perms.sh` (+4 -0) </details> ### 📄 Description Fixes https://github.com/jc21/nginx-proxy-manager/issues/1250 Somehow the owner of the logs is sometimes not root, which causes logrotate to fail. This makes sure that a failing of logrotate does not crash npm. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 08:30:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3403
No description provided.