[PR #1181] [MERGED] Fix wildcard domain regex #3391

New issue

Closed

opened 2026-02-26 08:30:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 08:30:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1181
Author: @tsallou
Created: 6/17/2021
Status: ✅ Merged
Merged: 7/18/2021
Merged by: @jc21

Base: develop ← Head: fix-wildcard-domains-regex

📝 Commits (1)

56c4f8a fix wildcard domains regex

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 frontend/js/app/nginx/certificates/form.js (+1 -1)
📝 frontend/js/app/nginx/proxy/form.js (+1 -1)

📄 Description

Hi,
I was trying to use wildcard domain on proxy host (*.example.org) but the frontend didn't respond how I wanted.

After a quick search in the code, it seem that the bug was introduce during #572 .
I found an open issue for this bug #749 .
I just changed the regex to match wildcard domain on proxy host like it is doing on dead and redirection host. I changed the wildcard certification regex too to match all the other.

It now works like a charm !

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1181 **Author:** [@tsallou](https://github.com/tsallou) **Created:** 6/17/2021 **Status:** ✅ Merged **Merged:** 7/18/2021 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `fix-wildcard-domains-regex` --- ### 📝 Commits (1) - [`56c4f8a`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/56c4f8a106dfa6c96d09028f67f2152d1ca752c3) fix wildcard domains regex ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/js/app/nginx/certificates/form.js` (+1 -1) 📝 `frontend/js/app/nginx/proxy/form.js` (+1 -1) </details> ### 📄 Description Hi, I was trying to use wildcard domain on proxy host (`*.example.org`) but the frontend didn't respond how I wanted. ![100749548-85098400-3430-11eb-8c01-74eafed92737](https://user-images.githubusercontent.com/58510131/122375649-b593b400-cf63-11eb-9927-1b3c1f4903c8.png) After a quick search in the code, it seem that the bug was introduce during #572 . I found an open issue for this bug #749 . I just changed the regex to match wildcard domain on proxy host like it is doing on dead and redirection host. I changed the wildcard certification regex too to match all the other. It now works like a charm ! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 08:30:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3391

No description provided.

Rows
Columns