[PR #1085] [MERGED] Improved new password error messages #3364

New issue

Closed

opened 2026-02-26 07:39:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:39:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1085
Author: @chaptergy
Created: 5/10/2021
Status: ✅ Merged
Merged: 5/12/2021
Merged by: @jc21

Base: develop ← Head: improved-new-password-error-messages

📝 Commits (1)

899b487 Puts backend errors into own error field

📊 Changes

2 files changed (+22 additions, -10 deletions)

View changed files

📝 frontend/js/app/user/password.ejs (+2 -1)
📝 frontend/js/app/user/password.js (+20 -9)

📄 Description

Currently error messages like the current password being incorrect were shown just below the new password input field (see linked issue). However the Invalid password is just the error message directly from the backend, so it doesn't make sense to associate it with a specific form field at all.

In this PR there is a new error segment added at the very top. In there, all backend errors are now displayed.

Fixes https://github.com/jc21/nginx-proxy-manager/issues/1082.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1085 **Author:** [@chaptergy](https://github.com/chaptergy) **Created:** 5/10/2021 **Status:** ✅ Merged **Merged:** 5/12/2021 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `improved-new-password-error-messages` --- ### 📝 Commits (1) - [`899b487`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/899b487daa9105592e25fefeafd017edd11abbb7) Puts backend errors into own error field ### 📊 Changes **2 files changed** (+22 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `frontend/js/app/user/password.ejs` (+2 -1) 📝 `frontend/js/app/user/password.js` (+20 -9) </details> ### 📄 Description Currently error messages like the current password being incorrect were shown just below the new password input field (see linked issue). However the _Invalid password_ is just the error message directly from the backend, so it doesn't make sense to associate it with a specific form field at all. In this PR there is a new error segment added at the very top. In there, all backend errors are now displayed. Fixes https://github.com/jc21/nginx-proxy-manager/issues/1082. ![image](https://user-images.githubusercontent.com/26956711/117704127-045a6b00-b1ba-11eb-8197-5ad3deadf0ed.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>