mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-26 01:45:54 +03:00
[PR #1081] [MERGED] Vipergts450 custom location patch #3361
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3361
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1081
Author: @vipergts450
Created: 5/8/2021
Status: ✅ Merged
Merged: 6/7/2021
Merged by: @jc21
Base:
develop← Head:vipergts450-custom_location-patch📝 Commits (8)
60347a9Update _location.confa3b896fUpdate _location.confe4e94d5Update nginx.js6a46e88Fix renderLocations to accept more parameters from host4c76803Rearrange _location.conf templatef26df7dUpdate nginx.jsca1ea04Update nginx.js69ee6b1Update nginx.js📊 Changes
2 files changed (+54 additions, -3 deletions)
View changed files
📝
backend/internal/nginx.js(+18 -3)📝
backend/templates/_location.conf(+36 -0)📄 Description
Possibly resolves jc21#148 jc21#590 but needs a lot of testing as I roughed this together. Probably can replace the top block with a modified
include conf.d/include/proxy.conf;Allows custom locations to follow the rules set on the primary page such as Websockets, forcing SSL, HSTS, etc.
Made a couple of amendments to
/backend/templates/_location.confand/backend/internal/nginx.jsto allow the custom location templates to have includes which should flesh out their configs and follow the settings of the main configuration page. Needs a lot of testing.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.