[PR #1017] [MERGED] Apply 'Force SSL' and 'Enable Websockets' to full host definition #3338

New issue

Closed

opened 2026-02-26 07:38:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:38:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1017
Author: @Stealthii
Created: 4/13/2021
Status: ✅ Merged
Merged: 4/29/2021
Merged by: @jc21

Base: develop ← Head: bugfix/config-application

📝 Commits (2)

f056b9d Move 'Force SSL' definitions to host root configuration
421934e Move 'Allow Websockets' definitions to host root configuration

📊 Changes

3 files changed (+10 additions, -9 deletions)

View changed files

📝 backend/templates/dead_host.conf (+1 -1)
📝 backend/templates/proxy_host.conf (+8 -7)
📝 backend/templates/redirection_host.conf (+1 -1)

📄 Description

The template options for these two options have been moved out of the root location block, and into the server block, in order for them to apply to custom locations set up via the proxy manager. This matches up with default expectations of how these toggle options work (as they are defined in the frontend host definition rather than the location).

If override behaviour is desired, these options can still be overridden by the existing "custom options" support offered.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/1017 **Author:** [@Stealthii](https://github.com/Stealthii) **Created:** 4/13/2021 **Status:** ✅ Merged **Merged:** 4/29/2021 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `bugfix/config-application` --- ### 📝 Commits (2) - [`f056b9d`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/f056b9dc7f94118b5d6ccb54661f466c2a0e3566) Move 'Force SSL' definitions to host root configuration - [`421934e`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/421934efedd12ba047f78243fb25388a613e29f8) Move 'Allow Websockets' definitions to host root configuration ### 📊 Changes **3 files changed** (+10 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/templates/dead_host.conf` (+1 -1) 📝 `backend/templates/proxy_host.conf` (+8 -7) 📝 `backend/templates/redirection_host.conf` (+1 -1) </details> ### 📄 Description The template options for these two options have been moved out of the root location block, and into the server block, in order for them to apply to custom locations set up via the proxy manager. This matches up with default expectations of how these toggle options work (as they are defined in the frontend host definition rather than the location). If override behaviour is desired, these options can still be overridden by the existing "custom options" support offered. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 07:38:56 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3338

No description provided.

Rows
Columns