[PR #850] [MERGED] Add new custom http.conf above includes for NPM-generated files #3306

Closed
opened 2026-02-26 07:38:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/850
Author: @MooBaloo
Created: 1/28/2021
Status: Merged
Merged: 2/1/2021
Merged by: @jc21

Base: developHead: master


📝 Commits (1)

  • 4ac52a0 Add custom .conf above includes for NPM-generated files.

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 docker/rootfs/etc/nginx/nginx.conf (+3 -0)

📄 Description

Added a new clause for custom http_top.conf above the include clauses for NPM-generated files. Allows for more flexibility with adding custom nginx .conf files to NPM

Use case: adding a configuration change needs to be present before other custom configuration files are called and reference configuration from the custom http_top.conf file.
Example: add a new log_format in http_top.conf, then referencing it in a access_log clause in server_proxy.conf.

Could also simply move the existing include for http.conf, but opted not to in case it breaks existing uses of http.conf.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/850 **Author:** [@MooBaloo](https://github.com/MooBaloo) **Created:** 1/28/2021 **Status:** ✅ Merged **Merged:** 2/1/2021 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `master` --- ### 📝 Commits (1) - [`4ac52a0`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/4ac52a0e25578fe16605e9bccc780f8ad0f16d4f) Add custom .conf above includes for NPM-generated files. ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docker/rootfs/etc/nginx/nginx.conf` (+3 -0) </details> ### 📄 Description Added a new clause for custom http_top.conf above the include clauses for NPM-generated files. Allows for more flexibility with adding custom nginx .conf files to NPM Use case: adding a configuration change needs to be present before other custom configuration files are called and reference configuration from the custom http_top.conf file. Example: add a new log_format in http_top.conf, then referencing it in a access_log clause in server_proxy.conf. Could also simply move the existing include for http.conf, but opted not to in case it breaks existing uses of http.conf. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 07:38:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3306
No description provided.