mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-26 01:45:54 +03:00
[PR #695] [MERGED] Adds autoremove of failed certificate creations in DB #3285
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3285
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/695
Author: @chaptergy
Created: 11/6/2020
Status: ✅ Merged
Merged: 11/9/2020
Merged by: @jc21
Base:
develop← Head:failed-certificate-autoremove📝 Commits (1)
1518ecdAdds autoremove of failed certificate creations in DB📊 Changes
1 file changed (+7 additions, -0 deletions)
View changed files
📝
backend/internal/certificate.js(+7 -0)📄 Description
This PR prevents certificates from showing up in the web interface when they failed to be created. No audit log is written, since nothing was changed. Up until now, an audit log entry was written, when the user had to manually delete the certificate, but when it was 'created', no log was written.
Fix https://github.com/jc21/nginx-proxy-manager/issues/629.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.