[PR #695] [MERGED] Adds autoremove of failed certificate creations in DB #3285

Closed
opened 2026-02-26 07:38:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/695
Author: @chaptergy
Created: 11/6/2020
Status: Merged
Merged: 11/9/2020
Merged by: @jc21

Base: developHead: failed-certificate-autoremove


📝 Commits (1)

  • 1518ecd Adds autoremove of failed certificate creations in DB

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 backend/internal/certificate.js (+7 -0)

📄 Description

This PR prevents certificates from showing up in the web interface when they failed to be created. No audit log is written, since nothing was changed. Up until now, an audit log entry was written, when the user had to manually delete the certificate, but when it was 'created', no log was written.

Fix https://github.com/jc21/nginx-proxy-manager/issues/629.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/695 **Author:** [@chaptergy](https://github.com/chaptergy) **Created:** 11/6/2020 **Status:** ✅ Merged **Merged:** 11/9/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `failed-certificate-autoremove` --- ### 📝 Commits (1) - [`1518ecd`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/1518ecd1e981ade371bea9c11e06844159116d3a) Adds autoremove of failed certificate creations in DB ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/certificate.js` (+7 -0) </details> ### 📄 Description This PR prevents certificates from showing up in the web interface when they failed to be created. No audit log is written, since nothing was changed. Up until now, an audit log entry was written, when the user had to manually delete the certificate, but when it was 'created', no log was written. Fix https://github.com/jc21/nginx-proxy-manager/issues/629. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 07:38:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3285
No description provided.